Conversation
|
|
|
|
||
| dip_sip: | ||
| filename: dip_sip.yml | ||
| topologies: [t0, t1, t1-lag] |
There was a problem hiding this comment.
We need t0-56 at least. It would be better to add all. #Closed
There was a problem hiding this comment.
@qiluo-msft We need to discuss which topologies must be supported by this testcase. Regarding t0-56, I have no way to check it. Basically, we can use any topology with this testcase which contains at least two PORT/LAG RIFs connected to neighbors, providing the valid LLDP info.
There was a problem hiding this comment.
Then it's ok to add all known topo here. Others can help you test. #Closed
There was a problem hiding this comment.
@qiluo-msft I have extended this testcase with the additional topologies as we discussed.
|
|
||
| from ptf import config | ||
| from ptf.base_tests import BaseTest | ||
| from ptf.testutils import * |
There was a problem hiding this comment.
Don't import wildcard. #Closed
| ip_ttl=self.pktTtl) | ||
| send(self.test, int(self.srcPortIds[0]), pkt) | ||
|
|
||
| pkt = simple_udp_packet(eth_dst=self.dstHostMac, |
There was a problem hiding this comment.
Should we also have one for IPv6?
There was a problem hiding this comment.
@prsunny Yes. Extended with IPv6 support.
| self.dstHostIpv6 = str(ip_address(unicode(self.testParams['dst_router_ipv6'])) + 1) | ||
|
|
||
| self.srcRouterMac = self.testParams['src_router_mac'] | ||
| self.srcRouterIpv4 = self.testParams['src_router_ipv4'] |
There was a problem hiding this comment.
Just a note, looks like srcRouterIPvX and srcHostIpvX are not used in the test.
There was a problem hiding this comment.
@prsunny Correct. It is just for logging purpose.
…-net#666) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Update calculation buffer in packet trimming case Fixes: In the packet trimming cases, it needs to calculate the available buffer size of the egress queue and then block the queue to trigger the trimming packet. There is a new feature "Update QoS to disable port alpha" (sonic-net/sonic-buildimage#23381). After the change, the calculation method of available buffer size has changed. So need update the buffer calculation function in trimming case ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Description of PR
The purpose of this test is to validate that SONiC switch supports routing of L3 packets with DIP=SIP
Type of change
Approach
How did you do it?
How did you verify/test it?
sudo -H ansible-playbook test_sonic.yml -i inventory --limit arc-switch1025-t0 -e testbed_name=arc-switch1025-t0 -e testbed_type=t0 -e testcase_name=dip_sip -vvvvv
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation