Skip to content

[everflow] address testbed setup type checking issue#6609

Merged
yxieca merged 1 commit intosonic-net:masterfrom
yxieca:everflow
Oct 25, 2022
Merged

[everflow] address testbed setup type checking issue#6609
yxieca merged 1 commit intosonic-net:masterfrom
yxieca:everflow

Conversation

@yxieca
Copy link
Copy Markdown
Collaborator

@yxieca yxieca commented Oct 25, 2022

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

everflow test is failing after PR #6225.

How did you do it?

Topology type are more than t2/t0/t1. !(t2) doesn't mean either T0 or T1. This PR fixes the branch error.

How did you verify/test it?

Run everflow test on test that is not T0/T1/T2.

Signed-off-by: Ying Xie ying.xie@microsoft.com

Topology type are more than t2/t0/t1. !(t2) doesn't mean either T0 or T1.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@azure-pipelines
Copy link
Copy Markdown

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/everflow/everflow_test_utilities.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/everflow/everflow_test_utilities.py:35:24: E261 at least two spaces before inline comment
tests/everflow/everflow_test_utilities.py:35:25: E262 inline comment should start with '# '
tests/everflow/everflow_test_utilities.py:110:121: E501 line too long (121 > 120 characters)
tests/everflow/everflow_test_utilities.py:112:121: E501 line too long (129 > 120 characters)
tests/everflow/everflow_test_utilities.py:166:38: E711 comparison to None should be 'if cond is not None:'
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxieca yxieca merged commit b55fe7f into sonic-net:master Oct 25, 2022
@yxieca yxieca deleted the everflow branch October 25, 2022 15:04
yxieca added a commit that referenced this pull request Oct 25, 2022
What is the motivation for this PR?
everflow test is failing after PR #6225.

How did you do it?
Topology type are more than t2/t0/t1. !(t2) doesn't mean either T0 or T1. This PR fixes the branch error.

How did you verify/test it?
Run everflow test on test that is not T0/T1/T2.

Signed-off-by: Ying Xie ying.xie@microsoft.com
StormLiangMS added a commit that referenced this pull request Oct 26, 2022
StormLiangMS added a commit to StormLiangMS/sonic-mgmt that referenced this pull request Oct 26, 2022
@StormLiangMS StormLiangMS mentioned this pull request Oct 26, 2022
6 tasks
yxieca pushed a commit that referenced this pull request Oct 26, 2022
* Revert "[everflow] address testbed setup type checking issue (#6609)"

This reverts commit b55fe7f.

* Revert "everflow test case fix (#6561)"

This reverts commit b497aa0.

* Revert "Everflow T2 topo support and ipv6 egress tests (#6225)"

This reverts commit c3f0980.
yxieca pushed a commit that referenced this pull request Oct 26, 2022
* Revert "[everflow] address testbed setup type checking issue (#6609)"

This reverts commit b55fe7f.

* Revert "everflow test case fix (#6561)"

This reverts commit b497aa0.

* Revert "Everflow T2 topo support and ipv6 egress tests (#6225)"

This reverts commit c3f0980.
allen-xf pushed a commit to allen-xf/sonic-mgmt that referenced this pull request Oct 28, 2022
What is the motivation for this PR?
everflow test is failing after PR sonic-net#6225.

How did you do it?
Topology type are more than t2/t0/t1. !(t2) doesn't mean either T0 or T1. This PR fixes the branch error.

How did you verify/test it?
Run everflow test on test that is not T0/T1/T2.

Signed-off-by: Ying Xie ying.xie@microsoft.com
allen-xf pushed a commit to allen-xf/sonic-mgmt that referenced this pull request Oct 28, 2022
* Revert "[everflow] address testbed setup type checking issue (sonic-net#6609)"

This reverts commit b55fe7f.

* Revert "everflow test case fix (sonic-net#6561)"

This reverts commit b497aa0.

* Revert "Everflow T2 topo support and ipv6 egress tests (sonic-net#6225)"

This reverts commit c3f0980.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants