Fix unexpected trailing symbol#6545
Merged
yejianquan merged 5 commits intosonic-net:masterfrom Oct 16, 2022
Merged
Conversation
a519a6b to
a82ad6e
Compare
a82ad6e to
0025bc0
Compare
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Oct 16, 2022
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
co-authorized by: jianquanye@microsoft.com * Fix unexpected trailing symbol Approach What is the motivation for this PR? With set -x, "##vso[task.setvariable variable=TEST_PLAN_ID]$TEST_PLAN_ID" get a chance to add a unexpected "'" as trailing symbol. microsoft/azure-pipelines-tasks#10331 I want to keep the set -ex setting, so the sub-steps that relies on TEST_PLAN_ID need to remove possible trailing symbol. A sample failure: https://dev.azure.com/mssonic/build/_build/results?buildId=160852&view=logs&j=37033ee9-5136-564d-6562-3f85a337b244&t=c7eb37a5-16b3-5b0b-a481-f1579bc7de47 How did you do it? Remove possible trailing symbol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
With set -x, "##vso[task.setvariable variable=TEST_PLAN_ID]$TEST_PLAN_ID" get a chance to add a unexpected "'" as trailing symbol.
microsoft/azure-pipelines-tasks#10331
I want to keep the set -ex setting, so the sub-steps that relies on TEST_PLAN_ID need to remove possible trailing symbol.
A sample failure:
https://dev.azure.com/mssonic/build/_build/results?buildId=160852&view=logs&j=37033ee9-5136-564d-6562-3f85a337b244&t=c7eb37a5-16b3-5b0b-a481-f1579bc7de47
Type of change
Back port request
Approach
What is the motivation for this PR?
With set -x, "##vso[task.setvariable variable=TEST_PLAN_ID]$TEST_PLAN_ID" get a chance to add a unexpected "'" as trailing symbol.
microsoft/azure-pipelines-tasks#10331
I want to keep the set -ex setting, so the sub-steps that relies on TEST_PLAN_ID need to remove possible trailing symbol.
A sample failure:
https://dev.azure.com/mssonic/build/_build/results?buildId=160852&view=logs&j=37033ee9-5136-564d-6562-3f85a337b244&t=c7eb37a5-16b3-5b0b-a481-f1579bc7de47
How did you do it?
Remove possible trailing symbol.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation