[syslog.yml]: Remove "Connection: Local"#652
Closed
praveen-li wants to merge 1 commit intosonic-net:masterfrom
Closed
[syslog.yml]: Remove "Connection: Local"#652praveen-li wants to merge 1 commit intosonic-net:masterfrom
praveen-li wants to merge 1 commit intosonic-net:masterfrom
Conversation
must not use Connection: local. This playbook is executed from controller. So "connection: local" will parse /var/log/syslog of controller server instead of DUT log file. Signed-off-by: Praveen Chaudhary <pchaudhary@linkedin.com>
jleveque
suggested changes
Jun 29, 2018
|
|
||
| # Check Messages | ||
| - name: Check syslog messages for the test message | ||
| connection: local |
Contributor
There was a problem hiding this comment.
The intended behavior here is to test the remote syslog behavior, therefore we actually want to check the local syslog in this step, to ensure the DUT sends its messages to the remote syslog server, which should be running on the local machine.
Member
Author
There was a problem hiding this comment.
Hi Joe
Thanks for review. In this case, kindly let me know. Do we need to manually start a remote syslog server on Controller or below steps in playbook are sufficient for this.
My guess is : below 2 modules does the job of starting remote syslog server.
- name: Add Rsyslog destination for testing
39 become: true
40 lineinfile:
41 line: ". @{{ local_srcip }}:{{ syslog_port }}"
42 dest: /etc/rsyslog.conf
43 state: present
44
45 - name: Restart Syslog Daemon
46 become: true
47 service: name=rsyslog state=restarted
-- I do not see syslogs coming to controller on my setup.
Contributor
There was a problem hiding this comment.
No, those lines configure rsyslog running on the DUT to be aware of the syslog server it should send to for the test. However, lines 51-95 should start the remote syslog server on the Ansible host.
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Oct 27, 2025
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-swss 24fcbb6..3cee6b8: > [aclorch]: Fix table name in counter table for mirror rules (sonic-net#1060) > Cannot ping to link-local ipv6 interface address of the switch. (sonic-net#774) > [MirrorOrch]: Mirror Session Retention across Warm Reboot (sonic-net#1062) Submodule src/sonic-utilities afaedb7..a06bee7: > [201811][config] Add '-h' and '-?' as help options to unify with show/sonic-clear cmds (sonic-net#654) > Revert "Fixed config Asym PFC CLI. (sonic-net#632)" (sonic-net#652) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* [201811][swss][utilities] advance sub module head Submodule src/sonic-swss fcd091c..9585be4: > [teamsyncd]: Check if LAG exists before removing (sonic-net#1069) > [mirrororch]: Toggle the mirror session when moving between VLAN/non-VLAN (sonic-net#1078) Submodule src/sonic-utilities 7bb6ffb..2d721de: > [show] Properly replace port name with alias in command output (sonic-net#664) > [neighbor_advertiser] hand pick partial change from sonic-net#525 (sonic-net#689) > Revert "Revert "Fixed config Asym PFC CLI. (sonic-net#632)" (sonic-net#652)" Signed-off-by: Ying Xie <ying.xie@microsoft.com> * address compile issue Submodule src/sonic-swss 9585be4..2529d79: > [mirrororch]: Address compiler switch issue (sonic-net#1079) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Pterosaur
pushed a commit
to Pterosaur/sonic-mgmt
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
[syslog.yml]: The module "Check syslog messages for the test message"must not use Connection: local.
This playbook is executed from controller. So "connection: local" will parse
/var/log/syslog of controller server instead of DUT log file.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Fixes # (issue)
Type of change
Approach
How did you do it?
Remove Connection Local in syslog.yml
How did you verify/test it?
http://172.25.11.20:8080/job/Run_Test_Cases_Msft_Ansible/74/console
Any platform specific information?
No
Supported testbed topology if it's a new test case?
Documentation