[t0-56-po2vlan] Fixed KeyError:'PortChannel201' to support tests on t0-56-po2vlan topology#6442
Merged
yxieca merged 1 commit intosonic-net:masterfrom Nov 3, 2022
Conversation
ppikh
previously approved these changes
Sep 29, 2022
liat-grozovik
previously approved these changes
Sep 30, 2022
Collaborator
|
@wangxin could you please have a look on that as well? if good, please merge |
…can run on t0 topo for support t0-56-po2vlan topology Signed-off-by: Anton <antonh@nvidia.com>
21eb80d
37380d5 to
21eb80d
Compare
Contributor
Author
|
Also added skip to lag_2 tests with PortChannel201 parameter. To avoid failures of these tests with error: |
ppikh
approved these changes
Oct 3, 2022
Collaborator
|
@yxieca could you please help to assign a reviewer? |
Collaborator
|
@yxieca kindly reminder, can you please help to assign a reviewer? |
yxieca
approved these changes
Nov 3, 2022
wangxin
pushed a commit
that referenced
this pull request
Nov 11, 2022
…can run on t0 topo for support t0-56-po2vlan topology (#6442) Description of PR This PR is continuing the work of fixing started in #6341 Many tests support t0 topology and they should be able to run on t0-56-po2vlan topology - but they fail with error: KeyError: u'PortChannel201' It happens because topology t0-56-po2vlan has 2 VLANs and tests expect that topology will have only 1 VLAN and the second VLAN has a PortChannel interface which is a member of the second VLAN(in regular t0 topo - all PortChannels are L3 interfaces) Added fix(remove additional VLAN/PortChannel from list of VLANs/Interfaces) for tests to support t0-56-po2vlan topology Summary: Fixed KeyError: u'PortChannel201' in tests which can run on t0 topo for support t0-56-po2vlan topology What is the motivation for this PR? Add support of t0-56-po2vlan topo for the test which can run on t0 topo How did you do it? Skipped the validation on the interfaces with extra Vlan/PortChannel. The rest interfaces can be tested as on regular t0 topo. How did you verify/test it? The test cases were executed after the change. Signed-off-by: Anton <antonh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…can run on t0 topo for support t0-56-po2vlan topology
Signed-off-by: Anton antonh@nvidia.com
Description of PR
This PR is continuing the work of fixing started in #6341
Many tests support t0 topology and they should be able to run on t0-56-po2vlan topology - but they fail with error: KeyError: u'PortChannel201'
It happens because topology t0-56-po2vlan has 2 VLANs and tests expect that topology will have only 1 VLAN and the second VLAN has a PortChannel interface which is a member of the second VLAN(in regular t0 topo - all PortChannels are L3 interfaces)
Added fix(remove additional VLAN/PortChannel from list of VLANs/Interfaces) for tests to support t0-56-po2vlan topology
Summary: Fixed KeyError: u'PortChannel201' in tests which can run on t0 topo for support t0-56-po2vlan topology
Type of change
Back port request
Approach
What is the motivation for this PR?
Add support of t0-56-po2vlan topo for the test which can run on t0 topo
How did you do it?
Skipped the validation on the interfaces with extra Vlan/PortChannel. The rest interfaces can be tested as on regular t0 topo.
How did you verify/test it?
The test cases were executed after the change.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation