Skip to content

Adding ACL scale test with error catching#638

Closed
simone-dell wants to merge 10 commits intosonic-net:masterfrom
simone-dell:acltb_scale_test
Closed

Adding ACL scale test with error catching#638
simone-dell wants to merge 10 commits intosonic-net:masterfrom
simone-dell:acltb_scale_test

Conversation

@simone-dell
Copy link
Copy Markdown
Contributor

Description of PR

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?
acltb_scale.yml gathers CRM information. Based on the free count returned, the test scales to fill up all the free space in the hardware. When an error is thrown, the scale number is returned.
How did you verify/test it?
Local repo
Any platform specific information?
No
Supported testbed topology if it's a new test case?
t1, t1-lag

Documentation

@simone-dell
Copy link
Copy Markdown
Contributor Author

Please don't merge this yet. This is part of a work in progress so we can figure out how to make this test platform agnostic, as CRM show command is sometimes different across platforms.

Copy link
Copy Markdown
Contributor

@qiluo-msft qiluo-msft Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[](start = 55, length = 1)

[](start = 55, length = 1)

Remove the blank? #Closed

Copy link
Copy Markdown
Contributor Author

@simone-dell simone-dell Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, thanks #Closed

vars:
command_to_run: "acl-loader update full /tmp/acltb_test_rules-del.json"
errors_expected: false
include: roles/test/tasks/run_command_with_log_analyzer.yml
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you consider checking remaining ACL entry count from CRM again after the ACL rules are deleted?

@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Apr 17, 2024

This scenario is already covered by test_stress_acl.py. I am closing this PR for now.

@wangxin wangxin closed this Apr 17, 2024
wangxin pushed a commit to wangxin/sonic-mgmt that referenced this pull request Oct 27, 2025
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…net#5288)

- Kernel: [201811] Fix I2C ISMT DMA buffer alignment issue (sonic-net#158)[201811] Fix I2C ISMT DMA buffer alignment issue (sonic-net#158)
- utilities: Fix pfcwd stats crash with invalid queue name (sonic-net#1077)
- sairedis: [syncd] Fix notification on switch shutdown request (sonic-net#638)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants