Add topology mark for test_fwutil.py#6231
Merged
wangxin merged 1 commit intosonic-net:masterfrom Sep 27, 2022
Merged
Conversation
The topology mark is missing from the test_fwutil.py. The script could be skipped unintentionally when topology requirement is specified. This change added the "any" topology mark. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
ZhaohuiS
approved these changes
Sep 27, 2022
wangxin
added a commit
that referenced
this pull request
Sep 28, 2022
The topology mark is missing from the test_fwutil.py. The script could be skipped unintentionally when topology requirement is specified. This change added the "any" topology mark. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
wangxin
added a commit
that referenced
this pull request
Sep 28, 2022
The topology mark is missing from the test_fwutil.py. The script could be skipped unintentionally when topology requirement is specified. This change added the "any" topology mark. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
6 tasks
ZhaohuiS
added a commit
that referenced
this pull request
Oct 10, 2022
What is the motivation for this PR? test_fwutil was introduced into nightly test in #6231, but all failed due to not found fixture. File an issue #6489 and skip it for now. How did you do it? Add skip section in platform test mark condition yml file. Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
wangxin
pushed a commit
that referenced
this pull request
Oct 11, 2022
What is the motivation for this PR? test_fwutil was introduced into nightly test in #6231, but all failed due to not found fixture. File an issue #6489 and skip it for now. How did you do it? Add skip section in platform test mark condition yml file. Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
wangxin
pushed a commit
that referenced
this pull request
Oct 11, 2022
What is the motivation for this PR? test_fwutil was introduced into nightly test in #6231, but all failed due to not found fixture. File an issue #6489 and skip it for now. How did you do it? Add skip section in platform test mark condition yml file. Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
The topology mark is missing from the test_fwutil.py. The script could be skipped unintentionally when topology requirement is specified. This change added the "any" topology mark. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
What is the motivation for this PR? test_fwutil was introduced into nightly test in sonic-net#6231, but all failed due to not found fixture. File an issue sonic-net#6489 and skip it for now. How did you do it? Add skip section in platform test mark condition yml file. Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
The topology mark is missing from the test_fwutil.py. The script could be skipped unintentionally when topology requirement is specified. This change added the "any" topology mark. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
What is the motivation for this PR? test_fwutil was introduced into nightly test in sonic-net#6231, but all failed due to not found fixture. File an issue sonic-net#6489 and skip it for now. How did you do it? Add skip section in platform test mark condition yml file. Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The topology mark is missing from the test_fwutil.py. The script could be
skipped unintentionally when topology requirement is specified.
How did you do it?
This change added the "any" topology mark.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation