Modified clean up section to include acldel to tmp folder#612
Closed
Anandaraj-Maharajan wants to merge 5 commits intosonic-net:masterfrom
Closed
Modified clean up section to include acldel to tmp folder#612Anandaraj-Maharajan wants to merge 5 commits intosonic-net:masterfrom
Anandaraj-Maharajan wants to merge 5 commits intosonic-net:masterfrom
Conversation
This checkin adds changes to perform save and reload test case for ACL rules
Using 'acl-loader delete' deleted all the ACLs including snmp/vty/data/erspan etc. However using 'acl-loader update <empty file> deletes only the dataacl. So reverting back to old change in always section.
After reload contents in /tmp folder will get removed. Adding changes to copy acl del file to clean up after reload
Added lines to copy acl del json file after reload
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Aug 2, 2025
…ch requests in test_restapi_vxlan_ecmp (sonic-net#612) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Since the PATCH request we call in `patch_config_vrouter_vrf_id_routes` is async, we can't verify the result right after we receive a response. Because of that, I've added a check of existing route via CLI before performing a GET request to get the list of routes from restapi. Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? Handle async behavior of PATCH request of restapi in the test #### How did you do it? Verified the change is applied via CLI before performing the GET request #### How did you verify/test it? Ran the test in a loop #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-utilities 7460f5c..4f72e14: > [config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (sonic-net#607) > [neighbor advertiser] try getting vlan addresses from o.s first (sonic-net#613) > [neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (sonic-net#612) Submodule src/sonic-swss 384c21e..46bc1f4: > [portsyncd]: Add default catch block in portsyncd (sonic-net#1033) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the clean up section to copy "acltb_test_rules-del.json" file in clean up section so that after reload, the acl rules get removed without any issue.
Description of PR
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation