Acl toggle interfaces test#593
Closed
simone-dell wants to merge 9 commits intosonic-net:masterfrom
simone-dell:acl-flap-interfaces
Closed
Acl toggle interfaces test#593simone-dell wants to merge 9 commits intosonic-net:masterfrom simone-dell:acl-flap-interfaces
simone-dell wants to merge 9 commits intosonic-net:masterfrom
simone-dell:acl-flap-interfaces
Conversation
Added ICMP test - create ptf icmp packet and make sure it is rejected based on drop icmp rule
Some of the changes initially done part of this PR are not applicable. reverting the same.
prsunny
reviewed
May 3, 2018
Contributor
prsunny
left a comment
There was a problem hiding this comment.
As commented. Rest of the changes looks good to me
| }, | ||
| "ip": { | ||
| "config": { | ||
| "protocol":1, |
Contributor
There was a problem hiding this comment.
Can you fix the alignment? Use space instead of tab.
Also I'm not sure why this is shown as a change. This looks already part of the existing code. Can you check?
3 tasks
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: This PR is to fix PFCWD test on Arista-7060X6 platform. Change list - Set rx_action to `forward` - Add new HWSKU name into `get_chip_name_if_asic_pfc_storm_supported` function - Update [pfc_storm_stop_arista_sonic.j2](https://github.com/sonic-net/sonic-mgmt/compare/master...bingwang-ms:fix_pfcwd_test_master?expand=1#diff-4c2e64fa2dd07405c55ce0689e069407560b4c487e3750b7739264f77c624a75) to change `python` to `python3` - Skip `forward` test temporarily ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? This PR is to fix PFCWD test on Arista-7060X6 platform. #### How did you do it? - Set rx_action to `forward` - Add new HWSKU name into `get_chip_name_if_asic_pfc_storm_supported` function - Update [pfc_storm_stop_arista_sonic.j2](https://github.com/sonic-net/sonic-mgmt/compare/master...bingwang-ms:fix_pfcwd_test_master?expand=1#diff-4c2e64fa2dd07405c55ce0689e069407560b4c487e3750b7739264f77c624a75) to change `python` to `python3` - Skip `forward` test temporarily #### How did you verify/test it? Change is verified by running the test on a physical testbed. #### Any platform specific information? No. #### Supported testbed topology if it's a new test case? Not a new test. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
… automatically (#23656) #### Why I did it src/sonic-platform-common ``` * 381432b - (HEAD -> 202505, origin/202505) [CMIS] Moving flat memory register handling from CmisMemMap to CmisFlatMemMap (sonic-net#592) (4 days ago) [mssonicbld] * 3e6a8ba - [CMIS] Remove application-dependent fields from get_transceiver_info (sonic-net#593) (4 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes # (issue)
Added a change to acltb.yml that toggles interfaces up/down to make sure acl rules are intact after port shutdown / no shutdown
Type of change
Approach
How did you do it? Added one step in the acl test run that toggles all interfaces up and down, reruns the PTF test, and makes sure that the tests still run after the interfaces are back up
How did you verify/test it? Ran it in my local repo
Any platform specific information? No
Supported testbed topology if it's a new test case? t1, t1-lag, t1-64-lag
Documentation