Closed
Conversation
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Jun 30, 2025
…P daemon (sonic-net#423) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? When using Chrony as the NTP daemon on the DUT, Chrony will not use NTP sources that have a root dispersion of more than 3 seconds (configurable via /etc/chrony/chrony.conf, but we currently don't touch that setting). #### How did you do it? Block here until the root dispersion is less than 3 seconds so that we don't incorrectly fail the test. #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-sairedis 54b02a1..8182916: > Add pre match to comparison logic and unittests (sonic-net#423) > Drop FDB notifications if they contain invalid OIDs (sonic-net#428) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
… automatically (sonic-net#18405) #### Why I did it src/sonic-platform-common ``` * ed3ec1f - (HEAD -> 202305, origin/202305) [202305] Implementing set_optoe_write_timeout API (sonic-net#423) (13 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Added new tests for QoS
Type of change
New tests
Approach
How did you do it?
Implemented new tests for covering QoS
How did you verify/test it?
Run it on the testbed.
Any platform specific information?
Tests were verified only on MLNX platforms
Supported testbed topology if it's a new test case?
t0, t1, t1-lag
Documentation