[CACL]Fix cacl test on dualtor testbed#4127
Merged
lguohan merged 1 commit intosonic-net:masterfrom Aug 27, 2021
Merged
Conversation
Signed-off-by: bingwang <bingwang@microsoft.com>
|
This pull request fixes 1 alert when merging 62c69c3 into 686259c - view on LGTM.com fixed alerts:
|
lguohan
approved these changes
Aug 27, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
PR sonic-net/sonic-buildimage#8477 added some iptable rules for DHCP on dualtor testbed, and the added rule will cause test_cacl_application failed. This PR addressed the issue by ignoring the dualtor specific rule on dualtor testbed. Signed-off-by: bingwang <bingwang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang bingwang@microsoft.com
Description of PR
Summary:
PR sonic-net/sonic-buildimage#8477 added some iptable rules for DHCP on dualtor testbed, and the added rule will cause
test_cacl_applicationfailed.This PR addressed the issue by ignoring the dualtor specific rule on dualtor testbed.
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to fix
test_cacl_applicationon dualtor testbed.How did you do it?
This PR addressed the issue by ignoring the dualtor specific rule on dualtor testbed.
How did you verify/test it?
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
No.
Documentation