Workaround for the announce_routes stuck issue#3557
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jun 1, 2021
Merged
Conversation
We observed that the announcing routes step may got stuck ocassionally. Possibly the stuck happened during HTTP posting to PTF docker to announce routes. This change made some changes to avoid the stuck forever issue. * Add timeout to the requests.post method. * Add try...except for the function calls of announcing routes in the announce_routes.py module. * Force the exabgp module to refresh supervisord in case of start and restart. * Remove the line of referring non-exist logger object in the announce_routes.py module. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Collaborator
|
/azp run |
bingwang-ms
approved these changes
Jun 1, 2021
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
We observed that the announcing routes step may got stuck ocassionally. Possibly the stuck happened during HTTP posting to PTF docker to announce routes. This change made some changes to avoid the stuck forever issue. * Add timeout to the requests.post method. * Add try...except for the function calls of announcing routes in the announce_routes.py module. * Force the exabgp module to refresh supervisord in case of start and restart. * Remove the line of referring non-exist logger object in the announce_routes.py module. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
We observed that the announcing routes step may got stuck ocassionally.
Possibly the stuck happened during HTTP posting to PTF docker to announce
routes.
How did you do it?
This change made some changes to avoid the stuck forever issue.
announce_routes.py module.
announce_routes.py module.
How did you verify/test it?
Tested
testbed-cli.sh restart-ptfandtestbed-cli.sh announce-routes.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation