Update 'get_crm_facts' helper function#3247
Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom Apr 1, 2021
Merged
Conversation
The command 'crm show resource all' is not available for some time after config reload. This PR adds a retry logic for handling this scenario. Signed-off-by: bingwang <bingwang@microsoft.com>
wangxin
reviewed
Mar 31, 2021
tests/common/devices/sonic.py
Outdated
| logging.warning("CRM counters are not ready yet, will retry after 10 seconds") | ||
| time.sleep(10) | ||
| timeout -= 10 | ||
| assert(timeout > 0) |
Collaborator
Author
There was a problem hiding this comment.
Good catch. Thanks
Fix comment.
wangxin
approved these changes
Mar 31, 2021
nirmalya-keysight
pushed a commit
to nirmalya-keysight/sonic-mgmt
that referenced
this pull request
Apr 5, 2021
* This PR updates 'get_crm_facts' function. The command 'crm show resource all' is not available for some time after config reload. This PR adds a retry logic for handling this scenario. Signed-off-by: bingwang <bingwang@microsoft.com>
saravanansv
pushed a commit
to saravanansv/sonic-mgmt
that referenced
this pull request
May 6, 2021
* This PR updates 'get_crm_facts' function. The command 'crm show resource all' is not available for some time after config reload. This PR adds a retry logic for handling this scenario. Signed-off-by: bingwang <bingwang@microsoft.com>
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
* This PR updates 'get_crm_facts' function. The command 'crm show resource all' is not available for some time after config reload. This PR adds a retry logic for handling this scenario. Signed-off-by: bingwang <bingwang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang bingwang@microsoft.com
Description of PR
Summary:
The command
crm show resource allis not available for some time after config reload.This PR adds a retry logic for handling this scenario.
Type of change
Approach
What is the motivation for this PR?
This PR is to fix
get_crm_factsfor some corner cases.How did you do it?
Add a retry logic.
How did you verify/test it?
Verified on 7050cx3-1.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
No.
Documentation