[Monit] Increase maximum value of Monit stable time in sanity check.#3171
Merged
yozhao101 merged 1 commit intosonic-net:masterfrom Mar 18, 2021
Merged
Conversation
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
wangxin
approved these changes
Mar 18, 2021
jleveque
approved these changes
Mar 18, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…ck. (sonic-net#3171) Signed-off-by: Yong Zhao <yozhao@microsoft.com> Summary: This PR aims to increase the maximum value of Monit stable time in sanity check. Fixes # (issue) Type of change [x ] Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Approach What is the motivation for this PR? When this PR (sonic-net#2890) was ran against virtual testbed, it restarted Monit service in the fixture after testing. This will cause the failure of sanity check for next test since Monit did not have enough time to initialize the states of services. How did you do it? I increase the maximum value of Monit stable time in sanity check. How did you verify/test it? I verify this on the virtual testbed by running the script kvmtest.sh to make sure pytest script can pass the test. Any platform specific information? N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yong Zhao yozhao@microsoft.com
Description of PR
Summary:
This PR aims to increase the maximum value of Monit stable time in sanity check.
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
When this PR (#2890) was ran against virtual testbed, it restarted Monit service in the fixture after testing. This will cause the failure of sanity check for next test since Monit did not have enough time to initialize the states of services.
How did you do it?
I increase the maximum value of Monit stable time in sanity check.
How did you verify/test it?
I verify this on the virtual testbed by running the script
kvmtest.shto make sure pytest script can pass the test.Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
Documentation