Skip to content

[crm] Ignore error messages for removing non-empty VLAN#2885

Merged
daall merged 1 commit intosonic-net:masterfrom
daall:crm_vlan_log_ignore
Jan 29, 2021
Merged

[crm] Ignore error messages for removing non-empty VLAN#2885
daall merged 1 commit intosonic-net:masterfrom
daall:crm_vlan_log_ignore

Conversation

@daall
Copy link
Copy Markdown
Contributor

@daall daall commented Jan 28, 2021

Signed-off-by: Danny Allen daall@microsoft.com

Description of PR

Summary: [crm] Ignore error messages for removing non-empty VLAN
Fixes #2871

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

We noticed in #2871 that even though the CRM test queues up VLAN updates in sequential order, the member removal can still happen after the VLAN removal. As expected, orchagent emits a failure log and retries the VLAN removal later, but this can cause issues in the test.

How did you do it?

Added a loganalyzer exception for VLAN removal errors.

How did you verify/test it?

Re-ran the test on a DUT in the lab. Noted the error message in the syslog, but the test was still able to pass.

Any platform specific information?

n/a

Supported testbed topology if it's a new test case?

n/a

Documentation

n/a

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall daall requested a review from a team January 28, 2021 23:57
@daall
Copy link
Copy Markdown
Contributor Author

daall commented Jan 29, 2021

/AzurePipeline run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@daall daall merged commit cf29199 into sonic-net:master Jan 29, 2021
@daall daall deleted the crm_vlan_log_ignore branch January 29, 2021 22:36
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…atically (sonic-net#16110)

src/sonic-utilities

* 0f001c56 - (HEAD -> 202205, origin/202205) UT change: for db_migrator test do not check for RESTAPI cert values (sonic-net#2919) (4 hours ago) [Vaibhav Hemant Dixit]
* 69d348d1 - [CLI][Show][BGP] Show BGP Change for no neighbor scenario (sonic-net#2885) (6 hours ago) [Dev Ojha]
* 4c6af3c3 - [multi-asic] Refine [override config table] for corner cases (sonic-net#2918) (6 hours ago) [wenyiz2021]
* bef3ffeb - [db_migrator] Set docker_routing_config_mode to the value obtained from minigraph parser (sonic-net#2890) (sonic-net#2922) (7 hours ago) [Vaibhav Hemant Dixit]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure to remove VLAN in CRM test

2 participants