clean up ecmp.yml test files#256
Merged
maggiemsft merged 2 commits intosonic-net:masterfrom Sep 4, 2017
Merged
Conversation
|
@maggiemsft, |
lguohan
reviewed
Aug 30, 2017
| @@ -1,8 +0,0 @@ | |||
| #!/bin/bash | |||
Contributor
There was a problem hiding this comment.
this is used by copp.yml
roles/test/tasks/copp.yml: script: roles/test/files/helpers/add_ip.sh
lguohan
requested changes
Aug 30, 2017
Contributor
lguohan
left a comment
There was a problem hiding this comment.
add_ip is used by copp.yml
lguohan
approved these changes
Sep 1, 2017
nhe-NV
pushed a commit
to nhe-NV/sonic-mgmt
that referenced
this pull request
May 12, 2025
…6_no_sid_blackhole (sonic-net#256) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Previously, the test case verified the dropping of 100 packets one-by-one, which was very slow. Now, we changed it to send 100 packets in a single batch and then verified the no-receiving behavior. Besides, there was a parsing error regarding the counter value when the platform is a mellanox device. I forgot to convert str to int before calculating the counter values. Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…et#10673) e46b243b Fix checkReplyType failed issue via recreating xcvr_table_helper on forking subprocess (sonic-net#255) (sonic-net#256) Signed-off-by: Stephen Sun <stephens@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these are files that looks like no longer needed after remove ptf ECMP tests.