Hardening syntax for string repalcement#243
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Aug 18, 2017
Merged
Conversation
stcheng
approved these changes
Aug 18, 2017
pavel-shirshov
approved these changes
Aug 18, 2017
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
May 30, 2025
…net#243) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> This PR fixes sonic-net#18166 . Summary: Fixes # (issue) sonic-net#18166 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…t#9412) c2aac75 [SFP-Refactor] Fix LP mode API issue (sonic-net#247) dba17c8 Firmware upgrade CLI support for QSFP-DD transceivers (sonic-net#244) cd69212 [SFP-Refactor] Implement CMIS Low Power mode (sonic-net#237) 9cea07f Fix RegGroupField decode (sonic-net#245) 6ae1909 Add CMIS QSFP support (sonic-net#246) c1f317d Gracefully handle CMIS APIs for passive modules (sonic-net#238) ec7335d fix for firmware functions (sonic-net#243) cf2ebe9 Fix RegBitField decode/encode (sonic-net#242) ef4f2c6 Fix SFP_CABLE_TECH_FIELD (sonic-net#240) e118644 remove time counting message in functions because function running time could be difficult to predict in unit tests (sonic-net#241) Signed-off-by: Prince George <prgeor@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.