Skip to content

[Platform API][Fan][PSU][FanDrawer] Fix typos in Fan_Drawer_fans test and PSU_fans test#2325

Merged
jleveque merged 1 commit intosonic-net:masterfrom
vdahiya12:changes_for_fixing_typos
Oct 10, 2020
Merged

[Platform API][Fan][PSU][FanDrawer] Fix typos in Fan_Drawer_fans test and PSU_fans test#2325
jleveque merged 1 commit intosonic-net:masterfrom
vdahiya12:changes_for_fixing_typos

Conversation

@vdahiya12
Copy link
Copy Markdown
Contributor

Summary:
fixing some typos in two tests

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

To improve the quality of the PSU Fans and Fan Drawers Fans platform API test

How did you do it?

Fixed the typos

How did you verify/test it?

Run PSU's fan tests , Fan Drawer Fan tests on a device with a populated platform.json present

Any platform specific information?

Platform must have a populated platform.json present

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@vdahiya12 vdahiya12 changed the title [Platform API][Fan][PSU][FanDrawer] fixing some typos in two tests [Platform API][Fan][PSU][FanDrawer] fixing some typos in Fan_Drawer_fans test and PSU_fans test Oct 10, 2020
@vdahiya12 vdahiya12 requested a review from jleveque October 10, 2020 03:04
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Oct 10, 2020

This pull request fixes 2 alerts when merging c56154b into 7b12d8f - view on LGTM.com

fixed alerts:

  • 2 for Unused local variable

@jleveque jleveque changed the title [Platform API][Fan][PSU][FanDrawer] fixing some typos in Fan_Drawer_fans test and PSU_fans test [Platform API][Fan][PSU][FanDrawer] Fix typos in Fan_Drawer_fans test and PSU_fans test Oct 10, 2020
@jleveque jleveque merged commit 205c866 into sonic-net:master Oct 10, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Update sonic-utilities submodule pointer to include the following:
* [route_check]: Ignore standalone tunnel routes (sonic-net#2325) ([sonic-net#2346](sonic-net/sonic-utilities#2346))
* [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([sonic-net#2333](sonic-net/sonic-utilities#2333))
* Subinterface vrf bind issue fix ([sonic-net#2211](sonic-net/sonic-utilities#2211))
* [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([sonic-net#2270](sonic-net/sonic-utilities#2270))
* Fix vrf UT failed issue ([sonic-net#2309](sonic-net/sonic-utilities#2309))

Signed-off-by: dprital <drorp@nvidia.com>

Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants