Add team docker and config files and interfaces file#23
Closed
stcheng wants to merge 3 commits intosonic-net:masterfrom
Closed
Add team docker and config files and interfaces file#23stcheng wants to merge 3 commits intosonic-net:masterfrom
stcheng wants to merge 3 commits intosonic-net:masterfrom
Conversation
qiluo-msft
requested changes
Oct 18, 2016
| register: if_copy | ||
| tags: network,unsafe | ||
| when: sonic_version == "v2" | ||
|
|
Contributor
There was a problem hiding this comment.
Why remove 'when' clause? #Closed
#Closed
Contributor
Author
There was a problem hiding this comment.
it is in sonicv2 folder so no need to have this #Closed
| owner=root | ||
| group=root | ||
| mode=0644 | ||
| register: if_copy |
Contributor
There was a problem hiding this comment.
Is it going to overwrite previous 'if_copy'?
| owner=root | ||
| group=root | ||
| mode=644 | ||
|
|
Contributor
There was a problem hiding this comment.
restart container after template?
lguohan
reviewed
Oct 19, 2016
ansible/roles/sonicv2/tasks/main.yml
Outdated
| - include: quagga.yml | ||
| tags: quagga,unsafe | ||
|
|
||
| - include: team.yml |
Contributor
There was a problem hiding this comment.
team [](start = 11, length = 4)
rename to teamd?
lguohan
reviewed
Oct 19, 2016
ansible/roles/sonicv2/tasks/team.yml
Outdated
| @@ -0,0 +1,10 @@ | |||
| - name: Start the team docker container | |||
Contributor
There was a problem hiding this comment.
teamd might be a better name.
lguohan
reviewed
Oct 19, 2016
ansible/roles/sonicv2/tasks/team.yml
Outdated
| - name: Start the team docker container | ||
| include: sonicdocker.yml | ||
| vars: | ||
| docker_container: team |
Contributor
There was a problem hiding this comment.
team [](start = 22, length = 4)
rename to teamd?
Contributor
lguohan
reviewed
Oct 19, 2016
| # | ||
| {% block banner %} | ||
| # =========== Managed by Ansible DO NOT EDIT! ======================== | ||
| # generated by templates/interfaces.j2 using minigraph_facts.py |
lguohan
reviewed
Oct 19, 2016
| {% block banner %} | ||
| # =========== Managed by Ansible DO NOT EDIT! ======================== | ||
| # generated by templates/interfaces.j2 using minigraph_facts.py | ||
| # file: vlan_interfaces |
Contributor
There was a problem hiding this comment.
vlan_interfaces [](start = 8, length = 15)
lag_interfaces
lguohan
reviewed
Oct 19, 2016
| {% endblock %} | ||
| # | ||
| {% block lag_interface %} | ||
| # The switch VLAN interfaces |
Contributor
There was a problem hiding this comment.
The switch VLAN interfaces [](start = 2, length = 26)
switch VLAN interfaces?
lguohan
reviewed
Oct 19, 2016
| address {{ interface['addr'] }} | ||
| netmask {{ interface['mask'] }} | ||
| {% endfor %} | ||
| {% endblock lag_interface %} |
Contributor
There was a problem hiding this comment.
we need bridges_ports here? Is this for lag for vlan?
lguohan
reviewed
Oct 19, 2016
| owner=root | ||
| group=root | ||
| mode=0644 | ||
| register: if_copy |
Contributor
There was a problem hiding this comment.
why do we seperate this file with the interfaces file?
Contributor
|
🕐 |
lguohan
requested changes
Oct 19, 2016
Contributor
lguohan
left a comment
There was a problem hiding this comment.
many questions, please address.
Contributor
Author
|
close this and open #69. |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Changes: Update submodule branch to 202012 [sonic-linkmgrd][202012] submodule update a8ddff5 Jing Zhang Fri Feb 25 11:38:28 2022 Incrementing tolerance on mux state inconsistency (sonic-net#27) a3f78a3 Jing Zhang Thu Feb 17 17:23:56 2022 Update log level for mux probing and mux state chance (sonic-net#23) 05156fb Jing Zhang Thu Feb 17 17:21:01 2022 Handle xcvrd crashing scenarios (sonic-net#22) 74529ef Longxiang Lyu Mon Feb 14 13:26:07 2022 [make] Enable make extra includes (sonic-net#24) sign-off: Jing Zhang zhangjing@microsoft.com
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[sonic-linkmgrd][202012] submodule update 0839af2 Longxiang Lyu Wed Jun 15 08:46:21 2022 +0800 [202012] Fix IP header checksum in handleSendSwitchCommand (sonic-net#89) afc4972 Jing Zhang Wed Jun 1 10:33:12 2022 -0700 Revert "Update log level for mux probing and mux state chance (sonic-net#23)" (sonic-net#85) ed52d0a Longxiang Lyu Tue May 31 10:28:30 2022 +0800 Add a command line option to store logs into a separate file (sonic-net#83) sign-off: Jing Zhang zhangjing@microsoft.com
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
linkmgrd: * d27ca81 2022-06-05 | Separate I2C mux state probing and gRPC forwarding state probing (sonic-net#86) (HEAD -> 202205) [Jing Zhang] * 9d7d301 2022-06-01 | Revert "Update log level for mux probing and mux state chance (sonic-net#23)" (sonic-net#85) [Jing Zhang] * 60d3d77 2022-06-05 | Fix peer mux wait back off factor (sonic-net#84) [Longxiang Lyu] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.