Temporary fix for lldp test code#229
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Jul 28, 2017
Merged
Conversation
lguohan
reviewed
Jul 28, 2017
|
|
||
| - name: verify the dut port description field is published correctly | ||
| assert: {that: "'{{ ansible_lldp_facts[neighbor_interface]['neighbor_port_desc'] }}' == dut_interface"} | ||
| assert: {that: "'{{ ansible_lldp_facts[neighbor_interface]['neighbor_port_desc'] }}' != ''"} |
Contributor
There was a problem hiding this comment.
add todo?
We need match accurate port description.
lguohan
reviewed
Jul 28, 2017
Contributor
lguohan
left a comment
There was a problem hiding this comment.
add todo comment. We need to match the accurate port description.
lguohan
approved these changes
Jul 28, 2017
lguohan
pushed a commit
that referenced
this pull request
Aug 3, 2017
* Temporary fix for lldp test code * (comment)
nhe-NV
pushed a commit
to nhe-NV/sonic-mgmt
that referenced
this pull request
May 12, 2025
…1 and t0 with service ports (sonic-net#229) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) 1. Reassign IP in topo_t0-isolated-d2u510.yml and topo_t1-isolated-d510u2.yml to avoid conflict with backplane ip of ptf 2. Fork topology with 2 service port(s) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? We need to avoid ip duplication between vm and backplane We need model service topo in topology #### How did you do it? 1. Reassign IP in topo_t0-isolated-d2u510.yml and topo_t1-isolated-d510u2.yml to avoid conflict with backplane ip of ptf 2. Fork topology with 1 or 2 service port(s) #### How did you verify/test it? NA #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
6f198d0 (HEAD -> 202012, origin/202012) [Y-Cable][Broadcom] upgrade to support Broadcom Y-Cable API to release (sonic-net#230) 1c3e422 SSD Health: Retrieve SSD health and temperature values from generic SSD info (sonic-net#229) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.