Skip to content

[action] [PR:20379] [tests]: Add tests for high frequency telemetry#22779

Merged
mssonicbld merged 2 commits intosonic-net:202511from
mssonicbld:cherry/202511/20379
Mar 23, 2026
Merged

[action] [PR:20379] [tests]: Add tests for high frequency telemetry#22779
mssonicbld merged 2 commits intosonic-net:202511from
mssonicbld:cherry/202511/20379

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Add tests for high frequency telemetry

How did you do it?

Add new test cases

How did you verify/test it?

Check in the sn5600 platform locally

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

What is the motivation for this PR?
Add tests for high frequency telemetry

How did you do it?
Add new test cases

How did you verify/test it?
Check in the sn5600 platform locally

Signed-off-by: mssonicbld <sonicbld@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #20379

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur
Copy link
Copy Markdown
Contributor

@vmittal-msft @liushilongbuaa

The CI failure (Pre_test Static Analysis) is not caused by this PR. The check-yaml hook fails due to a duplicate key in the base branch (202511):

while constructing a mapping
 in "tests/common/plugins/conditional_mark/tests_mark_conditions.yaml", line 9, column 1
found duplicate key "bgp/test_bgp_vnet.py" with value "{}" (original value: "{}")
 in "tests/common/plugins/conditional_mark/tests_mark_conditions.yaml", line 485, column 1

bgp/test_bgp_vnet.py appears twice in tests_mark_conditions.yaml (lines 479 and 485) on the 202511 branch. This PR only adds a high_frequency_telemetry entry to that file, but the check-yaml hook validates the entire file and catches the pre-existing duplicate.

Could you help fix the duplicate key on the 202511 branch so this PR's CI can pass? Thanks!

@Pterosaur
Copy link
Copy Markdown
Contributor

Update: This duplicate key issue on the 202511 branch is also blocking other open PRs that modify tests_mark_conditions.yaml. The following PRs targeting 202511 are failing the same check-yaml pre-commit hook due to the duplicate bgp/test_bgp_vnet.py key:

PR Title
#22793 Add conditional skip for test_load_minigraph_with_golden_config
#22321 avoid GCU ECN test for currently unsupported Cisco platforms
#22112 Adjusting test_stress_arp for ipv6-only topologies
#22041 skip test_vxlan_multi_tunnel.py due to missing feature
#22006 Support running acl tests without any IPv4 management configuration
#22779 Add tests for high frequency telemetry (this PR)

Fixing the duplicate key on 202511 would unblock all of these at once. cc @vmittal-msft @liushilongbuaa

Pterosaur added a commit to Pterosaur/sonic-mgmt that referenced this pull request Mar 8, 2026
Remove duplicate 'bgp/test_bgp_vnet.py' entry (lines 485-490) which is
identical to the first occurrence (lines 479-484). The duplicate key causes
check-yaml pre-commit hook failures on all PRs that modify this file.

This unblocks PRs sonic-net#22793, sonic-net#22779, sonic-net#22321, sonic-net#22112, sonic-net#22041, sonic-net#22006.

Signed-off-by: Ze Gan <ganze718@gmail.com>
vmittal-msft pushed a commit that referenced this pull request Mar 9, 2026
Remove duplicate 'bgp/test_bgp_vnet.py' entry (lines 485-490) which is
identical to the first occurrence (lines 479-484). The duplicate key causes
check-yaml pre-commit hook failures on all PRs that modify this file.

This unblocks PRs #22793, #22779, #22321, #22112, #22041, #22006.

Signed-off-by: Ze Gan <ganze718@gmail.com>
@Pterosaur
Copy link
Copy Markdown
Contributor

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur Pterosaur closed this Mar 10, 2026
@Pterosaur Pterosaur reopened this Mar 10, 2026
@Pterosaur Pterosaur requested review from BYGX-wcr and r12f as code owners March 10, 2026 17:39
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 20a0300 into sonic-net:202511 Mar 23, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants