Try docker login if docker registry username and password are defined#2233
Merged
wangxin merged 2 commits intosonic-net:masterfrom Sep 21, 2020
wangxin:docker-login-pr
Merged
Try docker login if docker registry username and password are defined#2233wangxin merged 2 commits intosonic-net:masterfrom wangxin:docker-login-pr
wangxin merged 2 commits intosonic-net:masterfrom
wangxin:docker-login-pr
Conversation
Not all docker registry have anonymous access enabled. This commit added code to firstly pull docker image. If pull failed, then try docker login. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
daall
reviewed
Sep 17, 2020
daall
approved these changes
Sep 18, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
swss 081d47b Update netlink messages handler (sonic-net#2233) de7c3eb [IntfMgrd] Retry adding ipv6 prefix by setting disabled_ipv6 flag (sonic-net#2267) utilities 2716ff2 [yang] extend ConfigMgmt constructor to pass YANG options (sonic-net#2118) 9fbe2ef [debug dump] dump interface module added (sonic-net#2070) a86da2d Add sonic-delayed.target to Application Extension .timer file generator (sonic-net#2176) 90611dd [portconfig] Allow to configure interface mtu for physical ports only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Not all docker registry have anonymous access enabled. Run
testbed-cli.sh add-topomay fail with pull PTF docker image to create PTF container.How did you do it?
This commit added code to try docker login if docker registry username and password are defined.
How did you verify/test it?
Logout from docker registry. Run add-topo. The scripts can automatically login to docker registry.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation