Fix test_stress_acl.py for t1-f2-d10u8 topo#22115
Merged
yxieca merged 1 commit intosonic-net:masterfrom Feb 4, 2026
Merged
Conversation
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@markx-arista can you create a cherry-pick to msft-202503 branch? |
7 tasks
Contributor
Author
|
yxieca
pushed a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Feb 4, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Manually cherry-picked from sonic-net/sonic-mgmt#22115 Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [x] 202503 - [x] 202511 ### Approach #### What is the motivation for this PR? test_stress_acl.py failed on t1-f2-d10u8 topo #### How did you do it? Randomly choose an upstream VM IP instead, like t1-isolated-* topos #### How did you verify/test it? test_stress_acl.py passed on t1-f2-d10u8 topo #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: markxiao <markxiao@arista.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com>
Anirudh-nokia
pushed a commit
to Anirudh-nokia/sonic-mgmt-fork
that referenced
this pull request
Feb 6, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: ayya <anirudh.ayya@nokia.com>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Feb 12, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 12, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Ravali Yeluri (WIPRO LIMITED) <v-ryeluri@microsoft.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Abhishek <abhishek@nexthop.ai>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 19, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com>
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Apr 1, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
albertovillarreal-keys
pushed a commit
to albertovillarreal-keys/sonic-mgmt
that referenced
this pull request
Apr 3, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Apr 13, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Apr 20, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
sudarshankumar4893
pushed a commit
to sudarshankumar4893/pervnetbgp-tests
that referenced
this pull request
Apr 20, 2026
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Sudarshan Kumar (from Dev Box) <sudakumar@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test.
We should randomly choose an upstream VM IP instead, like t1-isolated-* topos.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
test_stress_acl.py failed on t1-f2-d10u8 topo
How did you do it?
Randomly choose an upstream VM IP instead, like t1-isolated-* topos
How did you verify/test it?
test_stress_acl.py passed on t1-f2-d10u8 topo
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation