[sanity_check] Allow retry for BGP check#2192
Merged
lolyu merged 1 commit intosonic-net:masterfrom Sep 17, 2020
Merged
Conversation
d5cec5e to
4e7f9ab
Compare
4e7f9ab to
9c49cc4
Compare
neethajohn
requested changes
Sep 9, 2020
If pretest sanity checks fails and allow_recover is set, the BGP check after adaptive recovery might fail due to its short wait time(30s). Allowing the retry for BGP check when networking uptime is short to wait BGP session to be established. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
9c49cc4 to
5e3a655
Compare
yxieca
reviewed
Sep 14, 2020
yxieca
approved these changes
Sep 15, 2020
Collaborator
Author
|
@neethajohn, could you please take a look? |
wangxin
approved these changes
Sep 16, 2020
neethajohn
approved these changes
Sep 16, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…t#11384) utilities: * 9f496a0 2022-07-06 | Update load minigraph to load backend acl (sonic-net#2236) (HEAD -> 202205, github/202205) [Neetha John] * ea938e3 2022-07-07 | Add support for IP interface loopback action (sonic-net#2192) [Lior Avramov] * a0b04de 2022-07-07 | [show] add new CLI to show tunnel route objects (sonic-net#2255) [Jing Zhang] platform-daemon: * e03d6a9 2022-07-06 | [ycabled][grpc] Fix some time interval,options for grpc keep alive to work (sonic-net#271) (HEAD -> 202205, github/202205) [vdahiya12] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
If pretest sanity checks fails and allow_recover is set, the BGP check
after adaptive recovery might fail due to its short wait time(120s).
Allowing the retry for BGP check when networking uptime is short to
wait BGP session to be established.
Signed-off-by: Longxiang Lyu lolv@microsoft.com
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
In 7060 T1 nightly,
test_crmfails in BGP check with unestablished neighbors. The reason is that the testcase always starts with DUT that has several stopped services and processes. Sanity check tries to do an adaptive recovery withconfig reloadbut the BGP sessions fail to establish after the short wait time(120s).How did you do it?
Allow retries for
BGPcheck till networking uptime last enough.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation