Remove unnecessary hard coded skip scripts in run_tests.sh#2173
Merged
wangxin merged 1 commit intosonic-net:masterfrom Sep 2, 2020
wangxin:fix-skip-utils
Merged
Remove unnecessary hard coded skip scripts in run_tests.sh#2173wangxin merged 1 commit intosonic-net:masterfrom wangxin:fix-skip-utils
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:fix-skip-utils
Conversation
Two scripts "test_announce_routes.py" and "test_nbr_health.py" are hard coded as scripts to be skipped in run_tests.sh. This caused these two scripts are not executed while preparing the DUT for testing. Indeed, either "-t TOPOLOGY" or "-c TEST_CASES" must be specified in the run_tests.sh command line arguments. When "-t TOPOLOGY" is specified, the scripts with "utils" mark will be skipped during test execution. It's unnecessary to specify them in the skip list. When "-c TEST_CASE" is specified, the person running the command is responsible for the correctness of the TEST_CASES list. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
daall
approved these changes
Sep 2, 2020
yxieca
approved these changes
Sep 2, 2020
neethajohn
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
This PR is to fix the issue introduced in PR #2146
Type of change
Approach
What is the motivation for this PR?
Two scripts "test_announce_routes.py" and "test_nbr_health.py" are hard coded
as scripts to be skipped in run_tests.sh. This caused these two scripts are not
executed while preparing the DUT for testing.
Indeed, either "-t TOPOLOGY" or "-c TEST_CASES" must be specified in
the run_tests.sh command line arguments. When "-t TOPOLOGY" is specified,
the scripts with "utils" mark will be skipped during test execution. It's
unnecessary to specify them in the skip list. When "-c TEST_CASE" is specified,
the person running the command is responsible for the correctness of the
TEST_CASES list.
How did you do it?
Remove the two hard coded scripts to be skipped from the list:
How did you verify/test it?
Test run
./run_tests.sh -i veos_vtb -d vlab-01 -n vms-kvm-t0 -f vtestbed.csv -k debug -l warning -m individual -q 1 -a False -e --disable_loganalyzer -c 'test_interfaces.py bgp/test_bgp_fact.py bgp/test_bgp_gr_helper.py bgp/test_bgp_speaker.py cacl/test_cacl_application.py cacl/test_cacl_function.py dhcp_relay/test_dhcp_relay.py lldp/test_lldp.py ntp/test_ntp.py route/test_default_route.py snmp/test_snmp_cpu.py snmp/test_snmp_interfaces.py snmp/test_snmp_lldp.py snmp/test_snmp_pfc_counters.py snmp/test_snmp_queue.py syslog/test_syslog.py tacacs/test_rw_user.py tacacs/test_ro_user.py telemetry/test_telemetry.py' -p logs/1vlan. Thetest_announce_routes.pyscript is executed.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation