Change pytest CLI arguments position for discovering subfolder conftest.py#2146
Merged
wangxin merged 1 commit intosonic-net:masterfrom Sep 1, 2020
wangxin:run_tests_conftest
Merged
Change pytest CLI arguments position for discovering subfolder conftest.py#2146wangxin merged 1 commit intosonic-net:masterfrom wangxin:run_tests_conftest
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:run_tests_conftest
Conversation
…st.py Update the pytest CLI arguments position in the run_tests.sh script to ensure that conftest.py defined in subfolders can be discovered by pytest to avoid "unrecognized argument" issue. For more details, please refer to https://github.com/Azure/sonic-mgmt/blob/master/tests/README.md Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Collaborator
Author
|
retest this please |
daall
approved these changes
Aug 31, 2020
neethajohn
approved these changes
Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
If test script is specified after pytest command line options defined in any conftest.py, then the conftest.py defined in subfolder may not be discovered and loaded by pytest. This could lead to
unrecognized argumentissue.How did you do it?
Update the pytest CLI arguments position in the run_tests.sh script to ensure
that conftest.py defined in subfolders can be discovered by pytest to avoid
"unrecognized argument" issue.
For more details, please refer to https://github.com/Azure/sonic-mgmt/blob/master/tests/README.md
How did you verify/test it?
Run the script using individual and group mode.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation