[everflow] Refactor Everflow tests to support different config modes#2133
Merged
daall merged 2 commits intosonic-net:masterfrom Sep 8, 2020
Merged
[everflow] Refactor Everflow tests to support different config modes#2133daall merged 2 commits intosonic-net:masterfrom
daall merged 2 commits intosonic-net:masterfrom
Conversation
- Convert acl.json to a template - Add "config_mode" fixture to run tests against CLI or configlet Signed-off-by: Danny Allen <daall@microsoft.com>
|
This pull request introduces 2 alerts when merging f6bf8ff into 9da5e63 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 96cc84d into 9da5e63 - view on LGTM.com new alerts:
|
wangxin
approved these changes
Sep 4, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
How I did it Advance swss submodule head to include: c3fb52b 2022-02-04 | Fix for missing lossless PG profile on certain ports (sonic-swss-common update for Vnet tables sonic-net#2133) (HEAD -> 202012, github/202012) [Ying Xie] Signed-off-by: Ying Xie ying.xie@microsoft.com
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…#12974) utilities: * 4b51e41 2022-12-06 | [config] Add check in config interface ip command to block if the interface is portchannel member (sonic-net#2539) (HEAD -> 202205) [Sudharsan Dhamal Gopalarathnam] * e53b32e 2022-12-06 | [generate_dump] [Mellanox] Fix the duplicate dfw dump collection problem by adding symlinks (sonic-net#2536) [Vivek] * 0391221 2022-12-02 | [GCU] Add RemoveCreateOnlyDependency Validator/Generator (sonic-net#2500) [jingwenxie] * e3658e9 2022-04-13 | [scripts/fast-reboot] Shutdown remaining containers through systemd (sonic-net#2133) [Stepan Blyshchak] swss: * 1a4a5d9 2022-12-02 | [ACL] Support ACTION_COUNTER action in custom ACL table type (sonic-net#2550) [bingwang-ms] * 33b0a9e 2022-12-05 | [muxorch] Adding case for maintaining current state (sonic-net#2280) [Nikola Dancejic] sairedis: * b29bb45 2022-12-02 | enable cisco8000 SAI bulk API feature (sonic-net#1153) (HEAD -> 202205) [Keith Lu] Signed-off-by: Ying Xie <ying.xie@microsoft.com> Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
Description of PR
Summary: [everflow] Refactor Everflow tests to support different config modes
Type of change
Approach
What is the motivation for this PR?
There are multiple ways to configure ACLs/Everflow on a SONiC device, with two of the more prevalent ones being CLI and Configlet. We would like to be able to verify that both config methods produce the same results, however we don't want to write another set of test cases just to verify configlet.
How did you do it?
I made the following changes:
acl.jsonand configlet based ACL rules.How did you verify/test it?
Ran locally on two different platforms. No egress support:
Egress support:
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation