Skip to content

[drop_counter] Fix test failure of test_neighbor_link_down[L3_EGRESS_LINK_DOWN]#2130

Merged
bingwang-ms merged 3 commits intosonic-net:masterfrom
bingwang-ms:fix_drop_counter
Aug 25, 2020
Merged

[drop_counter] Fix test failure of test_neighbor_link_down[L3_EGRESS_LINK_DOWN]#2130
bingwang-ms merged 3 commits intosonic-net:masterfrom
bingwang-ms:fix_drop_counter

Conversation

@bingwang-ms
Copy link
Copy Markdown
Collaborator

@bingwang-ms bingwang-ms commented Aug 24, 2020

Description of PR

Summary:
Fixes # (issue)
There are two minor issues causing test failure in this case:

  1. The config file for arp_responder may containds duplicate ip addresses, which causes unexpected ARP table on DUT;
  2. The interface is down before ARP request is sent, which causes no ARP entry for selected IP address.
    This commit fix above issues.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

This PR is to fix test failure of test_neighbor_link_down.

How did you do it?

There are two minor issues causing test failure in this case as described in summary. This PR address these issues:

  1. Add a check for duplication before adding ip address to config file for arp_responder;
  2. Issue a ping before interface is down to populate ARP table on DUT.

How did you verify/test it?

Verify on Arista-7260:

========================================================================================= test session starts =========================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.8.1, pluggy-0.13.1 -- /usr/bin/python
cachedir: .pytest_cache
ansible: 2.8.7
rootdir: /data/Networking-acs-sonic-mgmt/tests, inifile: pytest.ini
plugins: forked-1.1.3, xdist-1.28.0, ansible-2.2.2, repeat-0.8.0
collected 2 items                                                                                                                                                                                     

drop_packets/test_configurable_drop_counters.py::test_neighbor_link_down[PORT_INGRESS_DROPS-L3_EGRESS_LINK_DOWN] PASSED                                                                         [ 50%]
drop_packets/test_configurable_drop_counters.py::test_neighbor_link_down[SWITCH_INGRESS_DROPS-L3_EGRESS_LINK_DOWN] SKIPPED                                                                      [100%]

------------------------------------------------------------------ generated xml file: /data/Networking-acs-sonic-mgmt/tests/tr.xml -------------------------------------------------------------------
================================================================================ 1 passed, 1 skipped in 83.44 seconds =================================================================================

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

N/A.

Documentation

N/A

@bingwang-ms
Fix test failure of test_neighbor_link_down[L3_EGRESS_LINK_DOWN]
70dfd63 
There are two minor issues causing test failure in this case:
1. The config file for arp_responder may containds duplicate ip
addresses, which causes unexpected ARP table on DUT;
2. The interface is down before ARP request is sent, which causes
no ARP entry for selected IP address.
This commit fix above issues.
@bingwang-ms bingwang-ms requested a review from a team August 24, 2020 08:54
daall
daall approved these changes Aug 24, 2020
View reviewed changes
@bingwang-ms bingwang-ms merged commit 7fa3647 into sonic-net:master Aug 25, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@judyjoseph
Update sonic-swss
16bb877 
5bb99c7 Validate LAG has members before mirror session create (sonic-net#2130)
ec6c8af [vxlan] Remove tunnel map objects on VNET tunnel removal (sonic-net#2150)
7e7db19 [BFD]Registering BFD state change callback during session creation (sonic-net#2202)
618fe07 [VNET]Fixing nexthop group delete during route change (sonic-net#2198)
91b66df [portsorch]: Prevent LAG member configuration when port has active ACL binding (sonic-net#2165)
29de9d0 Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197)
ded0b45 [PBH] Implement Edit Flows (sonic-net#2169)
2ee0f49 [neighsyncd] increase neighsyncd timeout (sonic-net#2209)
a0160c0 [QosOrch] The notifications cannot be drained in QosOrch in case the first one needs to retry (sonic-net#2206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@daall daall daall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bingwang-ms @daall