Skip to content

[dualtor] Fix test_stress_arp.py#20780

Merged
yxieca merged 1 commit intosonic-net:masterfrom
lolyu:fix_arp_stress
Sep 24, 2025
Merged

[dualtor] Fix test_stress_arp.py#20780
yxieca merged 1 commit intosonic-net:masterfrom
lolyu:fix_arp_stress

Conversation

@lolyu
Copy link
Copy Markdown
Collaborator

@lolyu lolyu commented Sep 23, 2025 •
edited
Loading

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Fix test_stress_arp (https://github.com/aristanetworks/sonic-qual.msft/issues/652):

  1. use enum_rand_one_per_hwsku_frontend_hostname on test functions
    test_stress_arp uses duthost as target DUT, but its fixture config_facts uses enum_rand_one_per_hwsku_frontend_hostname as the target DUT.
    Let's enforce the same DUT selection behavior.

  2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How did you do it?

As the motivation.

How did you verify/test it?

Run on active-standby dualtor.

arp/test_stress_arp.py::test_ipv4_arp[str2-7050cx3-32c-f-acs-08-None] PASSED                                     [ 33%]
arp/test_stress_arp.py::test_ipv6_nd[str2-7050cx3-32c-f-acs-08-None] PASSED                                      [ 66%]
arp/test_stress_arp.py::test_ipv6_nd_incomplete[str2-7050cx3-32c-f-acs-08-None] PASSED                           [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@lolyu
[dualtor] Fix test_stress_arp.py
7516a67 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Sep 23, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 23, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@lolyu lolyu requested review from bingwang-ms and yxieca September 24, 2025 01:11
@yxieca yxieca merged commit f8020e4 into sonic-net:master Sep 24, 2025
15 checks passed
@dhanasekar-arista dhanasekar-arista mentioned this pull request Sep 25, 2025
Closed
11 tasks
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Sep 30, 2025
@lolyu @mssonicbld
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
091db98 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Sep 30, 2025

Cherry-pick PR to 202505: #20867

@mssonicbld mssonicbld mentioned this pull request Sep 30, 2025
Merged
11 tasks
mssonicbld pushed a commit that referenced this pull request Sep 30, 2025
@lolyu @mssonicbld
[dualtor] Fix test_stress_arp.py (#20780)
6336cab 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
@lolyu @vidyac86
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
e0c78d2 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@lolyu
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
0756b46 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@vkjammala-arista vkjammala-arista mentioned this pull request Dec 9, 2025
Merged
12 tasks
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
@lolyu @gshemesh2
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
f3505a0 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@lolyu @AharonMalkin
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
d38212d 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@lolyu @gshemesh2
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
64aeadb 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@lolyu @venu-nexthop
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
303981b 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
yifan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 14, 2026
@lolyu @yifan-nexthop
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
d2978b1 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: YiFan Wang <yifan@nexthop.ai>
@mssonicbld mssonicbld mentioned this pull request Jan 20, 2026
Merged
12 tasks
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@lolyu @gshemesh2
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
05249fb 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
lakshmi-nexthop pushed a commit to lakshmi-nexthop/sonic-mgmt that referenced this pull request Jan 28, 2026
@lolyu @lakshmi-nexthop
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
434fb9b 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@lolyu @ytzur1
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
a8a1e44 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Yael Tzur <ytzur@nvidia.com>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
@lolyu @abhishek-nexthop
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
f3ab2c1 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
@lolyu
[dualtor] Fix test_stress_arp.py (sonic-net#20780)
c41ce09 
1. use `enum_rand_one_per_hwsku_frontend_hostname` on test functions
`test_stress_arp` uses `duthost` as target DUT, but its fixture
`config_facts` uses `enum_rand_one_per_hwsku_frontend_hostname` as the
target DUT.
Let's enforce the same DUT selection behavior.

2. add the missing toggle on active-standby dualtor.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca approved these changes

@bingwang-ms bingwang-ms Awaiting requested review from bingwang-ms

Assignees

No one assigned

Labels

Approved for 202505 branch Included in 202505 branch Request for 202505 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lolyu @mssonicbld @yxieca @yejianquan