[test_iface_namingmode] Adapt to show interfaces status fec column#2074
Closed
lolyu wants to merge 1 commit intosonic-net:masterfrom
Closed
[test_iface_namingmode] Adapt to show interfaces status fec column#2074lolyu wants to merge 1 commit intosonic-net:masterfrom
lolyu wants to merge 1 commit intosonic-net:masterfrom
Conversation
9f27416 to
b8e3a95
Compare
neethajohn
reviewed
Aug 10, 2020
b8e3a95 to
69e44d6
Compare
1. Modify `show_interface` module to support `SONIC_CLI_IFACE_MODE` 2. Modify `test_show_interfaces_status` to use `show_interface` to be compatible with the introduction of `fec`. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
69e44d6 to
1c36730
Compare
Collaborator
|
Will this enhancement #2080 be helpful for the problem addressed by this PR? |
Collaborator
Author
No, there is an extra requirement to run |
neethajohn
reviewed
Aug 11, 2020
| name = regex_int.match(line).group(1) | ||
| alias = regex_int.match(line).group(4) | ||
| intf_status = dutHostGuest.show_interface(command="status", | ||
| interfaces=(test_intf,), |
Collaborator
|
#2004 address the regex issue already. But I think Neetha's suggestion is great. we should move to use show_inteface libraray. |
Collaborator
Author
I see, thanks for the notice. |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Includes below commits ``` 38b616ba 2021-12-09 | [LGTM] lgtm to use 202106 branches of swss-common and sairedis (sonic-net#2074) [Stephen Sun] c68bad07 2021-12-07 | Fix random failure in PR/CI build. sonic-net#2006 [Shilong Liu] ba17675b 2021-08-23 | [ci]: fix artifacts download from swss-common and sairedis (sonic-net#1882) [Guohan Lu] ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Adapt to show interfaces status fec column
Signed-off-by: Longxiang Lyu lolv@microsoft.com
Type of change
Approach
What is the motivation for this PR?
test_iface_namingmodefailed due to the newfecinshow interfaces statusHow did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation