Fix: mac address change during oq watchdog test with soft_reset#20607
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Sep 11, 2025
Merged
Fix: mac address change during oq watchdog test with soft_reset#20607yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
The committers listed above are authorized under a signed CLA. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#697 |
xixuej
pushed a commit
to xixuej/sonic-mgmt
that referenced
this pull request
Sep 17, 2025
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com
dayouliu1
pushed a commit
to dayouliu1/sonic-mgmt
that referenced
this pull request
Sep 18, 2025
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Jan 28, 2026
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
Description of PR Recently, a new QoS test case was added, which triggered an issue: https://migsonic.atlassian.net/browse/MIGSMSFT-1203 The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that changes the MAC address was introduced in the following upstream PR: sonic-net#8149 After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices. Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms. signed-off-by: jianquanye@microsoft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Recently, a new QoS test case was added, which triggered an issue:
https://migsonic.atlassian.net/browse/MIGSMSFT-1203
The root cause is that during the test case, the system MAC address is changed after a soft reset. The script that
changes the MAC address was introduced in the following upstream PR: #8149
After debugging and discussion, it is confirmed that the script was added to fix a TD2-specific issue and is not applicable to Cisco devices.
Following the discussions, we implemented a fix to skip the MAC address setting for Cisco platforms.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation