[pytest] Fix unicode error in pfcwd#1993
Merged
neethajohn merged 1 commit intosonic-net:masterfrom Aug 3, 2020
Merged
Conversation
Signed-off-by: Neetha John <nejo@microsoft.com>
SavchukRomanLv
approved these changes
Jul 30, 2020
Contributor
Author
|
retest this please |
daall
approved these changes
Jul 31, 2020
Contributor
Author
|
retest this please |
yxieca
approved these changes
Aug 3, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update submodule sonic-utilities that contains the following commits: Revert "[202012] [generate_dump] allow to extend dump with plugin scripts (sonic-net#1945)" (sonic-net#1993) [soft-reboot] Add support for platforms based on Device Tree (sonic-net#1963) [Reclaiming buffer][202012] Database migrator for reclaiming buffer (sonic-net#1898) [202012] [generate_dump] allow to extend dump with plugin scripts (sonic-net#1945) Signed-off-by: dprital <drorp@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neetha John nejo@microsoft.com
Description of PR
Fixes the unicode error seen in pytest runs when selected port type is a 'portchannel'
E "stderr_lines": [
E "WARNING: No route found for IPv6 destination :: (no default route?)",
E "pfc_wd.PfcWdTest ... ERROR",
E "",
E "======================================================================",
E "ERROR: pfc_wd.PfcWdTest",
E "----------------------------------------------------------------------",
E "Traceback (most recent call last):",
E " File "ptftests/pfc_wd.py", line 56, in runTest",
E " while ip_src == ipaddress.IPv4Address(unicode(self.ip_dst,'utf-8')) or ip_src.is_multicast or ip_src.is_private or ip_src.is_global or ip_src.is_reserved:",
E "TypeError: decoding Unicode is not supported",
E "",
E "----------------------------------------------------------------------",
E "Ran 1 test in 0.003s",
E "",
E "FAILED (errors=1)"
E ],
Type of change
How did you verify/test it?
set pfcwd seed to 0 which will pick up a portchannel interface for the test on the setup I validated.
Ran the test without the changes which resulted in the error above
Ran pytest and the ansible test with the fix and they passed