Explicitly skip test_ser for unmatched asic_type#1972
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jul 29, 2020
wangxin:platform-skip-non-brcm
Merged
Explicitly skip test_ser for unmatched asic_type#1972yxieca merged 1 commit intosonic-net:masterfrom wangxin:platform-skip-non-brcm
yxieca merged 1 commit intosonic-net:masterfrom
wangxin:platform-skip-non-brcm
Conversation
Signed-off-by: Xin Wang <xiwang5@microsoft.com>
neethajohn
approved these changes
Jul 27, 2020
tahmed-dev
approved these changes
Jul 27, 2020
Collaborator
Author
|
retest this please |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
c48c363 Revert "[sonic-package-manager] support sonic-cli-gen and packages with YANG model (sonic-net#1650)" (sonic-net#1972)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The Broadcom specific test_ser.py script just logs a message and exit when
asic_typeis notbroadcom. When this test script is executed on other platforms, the script will be marked aspassed. This doesn't make sense.Type of change
Approach
What is the motivation for this PR?
When the Broadcom platform specific test script
test_ser.pyis executed on other platforms, the script will be marked aspassed. This does not make sense.How did you do it?
Explicitly skip the Broadcom specific tests on other platforms.
How did you verify/test it?
Test run the script on non Broadcom platforms, the test is marked as
skipped.Any platform specific information?
The updated script is Broadcom platform specific.
Supported testbed topology if it's a new test case?
Documentation