Skip to content

Add logging info for ipinip#194

Merged
stcheng merged 1 commit intosonic-net:masterfrom
sihuihan88:sihan/ipinip
Jun 6, 2017
Merged

Add logging info for ipinip#194
stcheng merged 1 commit intosonic-net:masterfrom
sihuihan88:sihan/ipinip

Conversation

@sihuihan88
Copy link
Copy Markdown
Contributor

No description provided.

@msftclas
Copy link
Copy Markdown

msftclas commented Jun 6, 2017

@sihuihan88,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

test_expect_file: decap_expect_messages.txt
match_file: loganalyzer_common_match.txt
ignore_file: loganalyzer_common_ignore.txt
tests_location: "{{ 'roles/test/tasks' }}"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see decap_*messages.txt, but I see loganaylyzer_common_match.txt, should we still use them?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using loganalyzer in this test, so we don't have to use those files as well.

@stcheng stcheng merged commit e312ba7 into sonic-net:master Jun 6, 2017
lguohan pushed a commit that referenced this pull request Aug 3, 2017
nhe-NV pushed a commit to nhe-NV/sonic-mgmt that referenced this pull request May 12, 2025
…sonic-net#194)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fix method collect_dut_lossless_prio.
The pfc_enable parameter can be empty.
Without this change we can get error:
```
> result = [int(x) for x in port_qos_map[intf]['pfc_enable'].split(',')]
E ValueError: invalid literal for int() with base 10: ''
```

PRs with related changes:
sonic-net/sonic-buildimage#22252
sonic-net/sonic-buildimage#22067

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
- [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [x] 202411

### Approach
#### What is the motivation for this PR?
stable test_pretest.py

#### How did you do it?
Used method `get`

#### How did you verify/test it?
Test passed after changes

<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
* 664f0e2 2021-07-14 | [xrcvd]: Removed undefined symbol 'sfp_status_helper' (sonic-net#204) (HEAD, origin/202012) [Prince George]
* 1b2d016 2021-06-16 | [CI] sonic-config-engine now depends on SONiC YANG packages (sonic-net#194) [Joe LeVeque]
* 1cf5996 2021-07-14 | Introduce mgmtinit delay after transceiver module insertion (sonic-net#201) [Prince George]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
… submodule head (sonic-net#12494)

utilities:
* 02eb899e 2022-07-12 | [config/load_mgmt_config] Support load IPv6 mgmt IP (sonic-net#2206) (sonic-net#2246) (sonic-net#2256) (HEAD -> 201811, github/201811) [Jing Kan]

platform-daemon:
* fc288cc 2022-05-05 | Mem leak caused by Xcvrd in Send-Q of REDIS-DB socket connection (sonic-net#260) (HEAD -> 201811, github/201811) [Prince George]

platform-common:
* edb062b 2022-02-09 | [sonic_sfp] Interpret sff 'int' element =0 as valid value (sonic-net#261) (HEAD -> 201811, github/201811) [Prince George]

kernel:
* 9d2d1a1 2022-02-11 | [201811] Increase log_buf_len size to 1M (HEAD -> 201811, github/201811) [Sujin Kang]
* b34a213 2022-02-10 | [201811] Increase log_buf_len size to 1M [Samuel Angebault]
* c4684cb 2022-02-11 | [201811] Apply kernel patches to fix emmc unreliability [Sujin Kang]
* df68771 2022-02-03 | [201811] Apply kernel patches to fix emmc unreliability [Samuel Angebault]
* f21cb06 2021-03-26 | [ci]: remove 201811 suffix (sonic-net#204) [lguohan]
* 5439b2a 2021-02-08 | [dni_dps460] Add attributes to retrieve PMBus status command codes (sonic-net#194) [Arun Saravanan Balachandran]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants