[sanity] remove disable sanity check marker in test files#1929
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jul 19, 2020
Merged
[sanity] remove disable sanity check marker in test files#1929yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
Test should not by default bypass sanity check. Bypassing sanity check could hide issues left from previous test(s). Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Collaborator
Author
|
retest vsimage please |
jleveque
approved these changes
Jul 19, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
4236bc4 [config reload] Fixing config reload when timer based delayed services are disabled (sonic-net#1967) d2514e4 [GCU] Different apply-patch runs should produce same sorted steps (sonic-net#1988) 2878adb [GCU] Using simulated config instead of target config when validating replace operation in NoDependencyMoveValidator (sonic-net#1987) fb8ca98 [GCU] Loading yang-models only once (sonic-net#1981) f88ee92 [GCU] Copying config_db before callding sonic_yang.loadData (sonic-net#1983) 9ed0e91 [GCU] Implementing DryRun by printing patch-sorter steps/imitating config_db (sonic-net#1973) b36b5e3 [GCU] Moving PatchSorter unit-test to json file to make it easier to read/maintain (sonic-net#1977) c0fa28b [generic-config-updater] Improving CreateOnly validator and marking /LOOPBACK_INTERFACE/LOOPBACK#/vrf_name as create-only (sonic-net#1969) 0559d04 [generic-config-updater] Adding non-strict mode (sonic-net#1929) b07f477 [debug dump util] FDB debug dump util changes (sonic-net#1968) 6d8757a [warm/fast-reboot] Fix kexec portion to support platforms based on Device Tree (sonic-net#1966) cc1409e [Auto Techsupport] Event driven Techsupport Bug Fixes (sonic-net#1986) 6c48bd5 Fix wrong help message for cable length setting (sonic-net#1978) c0bbbe3 [breakout] Fix the check when port is not present in BREAKOUT_CFG table (sonic-net#1765) 5bb8cad [doc][DPB] Update DPB related interface breakout command Info (sonic-net#1438) e6fd990 [config] Fix 'config reload -l' command to get filename by default (sonic-net#1611) bd8f7bb Update swss_ready check to check per namespace swss service (sonic-net#1974) 5439f94 [soft-reboot] Add support for platforms based on Device Tree (sonic-net#1963) 7c5810a [config] Add portchannel support for static route (sonic-net#1857) 7cb6a1b preserve old order for config reload (sonic-net#1964) 20bddbd [Auto-Techsupport] Issues related to Multiple Cores crashing handled (sonic-net#1948)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Test should not by default bypass sanity check. Bypassing sanity check could hide issues left from previous test(s).
How did you do it?
Enabled test module level default sanity test for all modules.