Skip to content

Add the topology mark missed in couple of scripts#1899

Merged
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:add-topo-marker
Jul 16, 2020
Merged

Add the topology mark missed in couple of scripts#1899
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:add-topo-marker

Conversation

@wangxin
Copy link
Copy Markdown
Collaborator

@wangxin wangxin commented Jul 14, 2020

Description of PR

Summary:
Fixes # (issue)

The topology mark is mandatory for all test scripts. Some of
the scripts don't have this mark somehow. This change is to
add topology mark to these scripts.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Without topology mark in test script, these script will be skipped if --topology pytest cli argument is given.

How did you do it?

Add topology mark to the scripts.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

The topology mark is mandatory for all test scripts. Some of
the scripts don't have this mark somehow. This change is to
add topology mark to these scripts.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
@wangxin wangxin requested a review from a team July 14, 2020 03:58
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jul 14, 2020

This pull request fixes 1 alert when merging 5feb0b5 into 40307fd - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@yxieca
Copy link
Copy Markdown
Collaborator

yxieca commented Jul 15, 2020

@daall please take a look at this change. I was surprised that we have to add tag for drop counter test again. I realized that I merged PR #1847, you might want to take a look to see if anything else is missing from that PR.

We can probably move on with Xin's change first and letting you analyze the difference offline?

@yxieca yxieca requested a review from daall July 15, 2020 02:55
@daall
Copy link
Copy Markdown
Contributor

daall commented Jul 15, 2020

@daall please take a look at this change. I was surprised that we have to add tag for drop counter test again. I realized that I merged PR #1847, you might want to take a look to see if anything else is missing from that PR.

We can probably move on with Xin's change first and letting you analyze the difference offline?

I'll take a look offline.

@wangxin wangxin merged commit bdc4619 into sonic-net:master Jul 16, 2020
@wangxin wangxin deleted the add-topo-marker branch July 20, 2020 08:58
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
sonic-swss commits

5fbd113 [Flex-counters] Fix the delay of flex counters flow to prevent infinite loop (sonic-net#1899)
dc685b6 [portsorch] Add an extra check before setting oper speed to APPL_DB (sonic-net#1885)
ceef728 Update port_rates & rif_rates lua scripts to convert poll_interval to MS (sonic-net#1855)

sonic-utilities commits

3160753 [ci]: Support PR coverage (sonic-net#1806)
3316fdb fix wrong code indent in sfputil (sonic-net#1808)
c33e3a8 [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814)
4f7e107 [portconfig] Validate duplicate speed value and interface type value (sonic-net#1745)
59817e2 [warm-reboot] Add new preboot health check: verify database integrity (sonic-net#1785)
bf2ff3c [portstat, intfstat] added rates and utilization (sonic-net#1750)
3bf962c [show][platform] Revise chassis info fallback to only fall back on pmon crash (sonic-net#1751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants