Skip to content

Skip test_cacl_application for PR test temporarily#18785

Merged
yejianquan merged 1 commit intosonic-net:masterfrom
ZhaohuiS:ZhaohuiS/skip_cacl_application
Jun 4, 2025
Merged

Skip test_cacl_application for PR test temporarily#18785
yejianquan merged 1 commit intosonic-net:masterfrom
ZhaohuiS:ZhaohuiS/skip_cacl_application

Conversation

@ZhaohuiS
Copy link
Copy Markdown
Contributor

@ZhaohuiS ZhaohuiS commented Jun 4, 2025

Description of PR

Summary:
Fixes # (issue)
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

Disable test_cacl_application in PR test temporarily for merging submodule PR.

>       pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}"
                      .format(repr(missing_iptables_rules)))
E       Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'}

For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps:

  1. skip test_cacl_application from PR test
  2. imagebuild PR get merged
  3. update test case
  4. add test_cacl_application back for PR test

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

How did you do it?

Disable test_cacl_application in PR test temporarily for merging submodule PR.

How did you verify/test it?

Retrigger PR test for sonic-host-services submodule advance PR.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
@yejianquan
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan yejianquan merged commit 5dffdeb into sonic-net:master Jun 4, 2025
18 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 4, 2025
Description of PR
Summary:
Fixes # (issue)
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

Disable test_cacl_application in PR test temporarily for merging submodule PR.

>       pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}"
                      .format(repr(missing_iptables_rules)))
E       Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'}
For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps:

skip test_cacl_application from PR test
imagebuild PR get merged
update test case
add test_cacl_application back for PR test
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

How did you do it?
Disable test_cacl_application in PR test temporarily for merging submodule PR.

How did you verify/test it?
Retrigger PR test for sonic-host-services submodule advance PR.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #18791

mssonicbld pushed a commit that referenced this pull request Jun 4, 2025
Description of PR
Summary:
Fixes # (issue)
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

Disable test_cacl_application in PR test temporarily for merging submodule PR.

>       pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}"
                      .format(repr(missing_iptables_rules)))
E       Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'}
For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps:

skip test_cacl_application from PR test
imagebuild PR get merged
update test case
add test_cacl_application back for PR test
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

How did you do it?
Disable test_cacl_application in PR test temporarily for merging submodule PR.

How did you verify/test it?
Retrigger PR test for sonic-host-services submodule advance PR.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
Description of PR
Summary:
Fixes # (issue)
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

Disable test_cacl_application in PR test temporarily for merging submodule PR.

>       pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}"
                      .format(repr(missing_iptables_rules)))
E       Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'}
For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps:

skip test_cacl_application from PR test
imagebuild PR get merged
update test case
add test_cacl_application back for PR test
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

How did you do it?
Disable test_cacl_application in PR test temporarily for merging submodule PR.

How did you verify/test it?
Retrigger PR test for sonic-host-services submodule advance PR.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
Description of PR
Summary:
Fixes # (issue)
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

Disable test_cacl_application in PR test temporarily for merging submodule PR.

>       pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}"
                      .format(repr(missing_iptables_rules)))
E       Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'}
For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps:

skip test_cacl_application from PR test
imagebuild PR get merged
update test case
add test_cacl_application back for PR test
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

How did you do it?
Disable test_cacl_application in PR test temporarily for merging submodule PR.

How did you verify/test it?
Retrigger PR test for sonic-host-services submodule advance PR.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
Description of PR
Summary:
Fixes # (issue)
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

Disable test_cacl_application in PR test temporarily for merging submodule PR.

>       pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}"
                      .format(repr(missing_iptables_rules)))
E       Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'}
For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps:

skip test_cacl_application from PR test
imagebuild PR get merged
update test case
add test_cacl_application back for PR test
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

How did you do it?
Disable test_cacl_application in PR test temporarily for merging submodule PR.

How did you verify/test it?
Retrigger PR test for sonic-host-services submodule advance PR.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
Description of PR
Summary:
Fixes # (issue)
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

Disable test_cacl_application in PR test temporarily for merging submodule PR.

>       pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}"
                      .format(repr(missing_iptables_rules)))
E       Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'}
For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps:

skip test_cacl_application from PR test
imagebuild PR get merged
update test case
add test_cacl_application back for PR test
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

How did you do it?
Disable test_cacl_application in PR test temporarily for merging submodule PR.

How did you verify/test it?
Retrigger PR test for sonic-host-services submodule advance PR.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
Description of PR
Summary:
Fixes # (issue)
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

Disable test_cacl_application in PR test temporarily for merging submodule PR.

>       pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}"
                      .format(repr(missing_iptables_rules)))
E       Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'}
For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps:

skip test_cacl_application from PR test
imagebuild PR get merged
update test case
add test_cacl_application back for PR test
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

How did you do it?
Disable test_cacl_application in PR test temporarily for merging submodule PR.

How did you verify/test it?
Retrigger PR test for sonic-host-services submodule advance PR.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
Description of PR
Summary:
Fixes # (issue)
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

Disable test_cacl_application in PR test temporarily for merging submodule PR.

>       pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}"
                      .format(repr(missing_iptables_rules)))
E       Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'}
For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps:

skip test_cacl_application from PR test
imagebuild PR get merged
update test case
add test_cacl_application back for PR test
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

How did you do it?
Disable test_cacl_application in PR test temporarily for merging submodule PR.

How did you verify/test it?
Retrigger PR test for sonic-host-services submodule advance PR.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
Description of PR
Summary:
Fixes # (issue)
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

Disable test_cacl_application in PR test temporarily for merging submodule PR.

>       pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}"
                      .format(repr(missing_iptables_rules)))
E       Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'}
For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps:

skip test_cacl_application from PR test
imagebuild PR get merged
update test case
add test_cacl_application back for PR test
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.

How did you do it?
Disable test_cacl_application in PR test temporarily for merging submodule PR.

How did you verify/test it?
Retrigger PR test for sonic-host-services submodule advance PR.

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants