Skip to content

[BGP Tests] Enable Tests for LT2 and FT2 Topologies#18669

Merged
yejianquan merged 2 commits intosonic-net:masterfrom
matthew-soulsby:add-lt2-topo-type
Jun 2, 2025
Merged

[BGP Tests] Enable Tests for LT2 and FT2 Topologies#18669
yejianquan merged 2 commits intosonic-net:masterfrom
matthew-soulsby:add-lt2-topo-type

Conversation

@matthew-soulsby
Copy link
Copy Markdown
Contributor

@matthew-soulsby matthew-soulsby commented May 28, 2025

Description of PR

Summary:
Small PR to add support for LT2 in BGP tests, through the use of an appropriate setup function for the platform.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

To ensure that we can run the BGP tests on the Lower T2 platform, we needed to add explicit support and initial testing for these testcases.

How did you do it?

Added lt2 to the list of topologies that uses the t1 & t2 interface setup function.

How did you verify/test it?

Running the previously failing tests, we can observe that they pass:
image
Other than loganalyzer fail, all testcases run successfully:
image

Any platform specific information?

Change is only relevant to the LT2 platform - all others are unaffected by this change.

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread ansible/roles/test/files/ptftests/py3/hash_test.py Outdated
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread tests/bgp/conftest.py Outdated
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@matthew-soulsby matthew-soulsby changed the title [BGP Tests] Add LT2 Support [BGP Tests] Enable Tests for LT2 and FT2 Topologies May 29, 2025
Copy link
Copy Markdown
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 36e0159 into sonic-net:master Jun 2, 2025
16 checks passed
yejianquan pushed a commit that referenced this pull request Jun 2, 2025
…8739)

Manual cherry-pick for #18669

Description of PR
Summary:
Small PR to add support for LT2 in BGP tests, through the use of an appropriate setup function for the platform.

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
To ensure that we can run the BGP tests on the Lower T2 platform, we needed to add explicit support and initial testing for these testcases.

How did you do it?
Added lt2 to the list of topologies that uses the t1 & t2 interface setup function.

How did you verify/test it?
Running the previously failing tests, we can observe that they pass:
image
Other than loganalyzer fail, all testcases run successfully:
image

Any platform specific information?
Change is only relevant to the LT2 platform - all others are unaffected by this change.

signed-off-by: jianquanye@microsoft.com
@mssonicbld
Copy link
Copy Markdown
Collaborator

@matthew-soulsby PR conflicts with 202505 branch

@matthew-soulsby matthew-soulsby deleted the add-lt2-topo-type branch June 2, 2025 03:55
bachalla pushed a commit to bachalla/sonic-mgmt that referenced this pull request Jun 2, 2025
Description of PR
Summary:
Small PR to add support for LT2 in BGP tests, through the use of an appropriate setup function for the platform.

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
To ensure that we can run the BGP tests on the Lower T2 platform, we needed to add explicit support and initial testing for these testcases.

How did you do it?
Added lt2 to the list of topologies that uses the t1 & t2 interface setup function.

How did you verify/test it?
Running the previously failing tests, we can observe that they pass:
image
Other than loganalyzer fail, all testcases run successfully:
image

Any platform specific information?
Change is only relevant to the LT2 platform - all others are unaffected by this change.

signed-off-by: jianquanye@microsoft.com
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
Description of PR
Summary:
Small PR to add support for LT2 in BGP tests, through the use of an appropriate setup function for the platform.

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
To ensure that we can run the BGP tests on the Lower T2 platform, we needed to add explicit support and initial testing for these testcases.

How did you do it?
Added lt2 to the list of topologies that uses the t1 & t2 interface setup function.

How did you verify/test it?
Running the previously failing tests, we can observe that they pass:
image
Other than loganalyzer fail, all testcases run successfully:
image

Any platform specific information?
Change is only relevant to the LT2 platform - all others are unaffected by this change.

signed-off-by: jianquanye@microsoft.com

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
Description of PR
Summary:
Small PR to add support for LT2 in BGP tests, through the use of an appropriate setup function for the platform.

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
To ensure that we can run the BGP tests on the Lower T2 platform, we needed to add explicit support and initial testing for these testcases.

How did you do it?
Added lt2 to the list of topologies that uses the t1 & t2 interface setup function.

How did you verify/test it?
Running the previously failing tests, we can observe that they pass:
image
Other than loganalyzer fail, all testcases run successfully:
image

Any platform specific information?
Change is only relevant to the LT2 platform - all others are unaffected by this change.

signed-off-by: jianquanye@microsoft.com
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
Description of PR
Summary:
Small PR to add support for LT2 in BGP tests, through the use of an appropriate setup function for the platform.

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
To ensure that we can run the BGP tests on the Lower T2 platform, we needed to add explicit support and initial testing for these testcases.

How did you do it?
Added lt2 to the list of topologies that uses the t1 & t2 interface setup function.

How did you verify/test it?
Running the previously failing tests, we can observe that they pass:
image
Other than loganalyzer fail, all testcases run successfully:
image

Any platform specific information?
Change is only relevant to the LT2 platform - all others are unaffected by this change.

signed-off-by: jianquanye@microsoft.com
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
Description of PR
Summary:
Small PR to add support for LT2 in BGP tests, through the use of an appropriate setup function for the platform.

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202205
 202305
 202311
 202405
 202411
 202505
Approach
What is the motivation for this PR?
To ensure that we can run the BGP tests on the Lower T2 platform, we needed to add explicit support and initial testing for these testcases.

How did you do it?
Added lt2 to the list of topologies that uses the t1 & t2 interface setup function.

How did you verify/test it?
Running the previously failing tests, we can observe that they pass:
image
Other than loganalyzer fail, all testcases run successfully:
image

Any platform specific information?
Change is only relevant to the LT2 platform - all others are unaffected by this change.

signed-off-by: jianquanye@microsoft.com
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants