add test for feature switch frr_bmp#18346
Merged
qiluo-msft merged 20 commits intosonic-net:masterfrom May 24, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
qiluo-msft
reviewed
May 12, 2025
| config = self.overwrite_feature_golden_config_db_multiasic(config, "frr_bmp") | ||
| config = self.overwrite_feature_golden_config_db_multiasic(config, "bmp") | ||
| else: | ||
| config = self.overwrite_feature_golden_config_db_singleasic(config, "frr_bmp") |
Contributor
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
May 24, 2025
bachalla
pushed a commit
to bachalla/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
Approach What is the motivation for this PR? Enable frr_bmp in mgmt test, also added test case for covering monit log checking. How did you do it? Add golden_config overwrite for frr_bmp, add test case into monit. How did you verify/test it? Existing kvm test verifies the sanity and new test path.
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Approach What is the motivation for this PR? Enable frr_bmp in mgmt test, also added test case for covering monit log checking. How did you do it? Add golden_config overwrite for frr_bmp, add test case into monit. How did you verify/test it? Existing kvm test verifies the sanity and new test path. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Approach What is the motivation for this PR? Enable frr_bmp in mgmt test, also added test case for covering monit log checking. How did you do it? Add golden_config overwrite for frr_bmp, add test case into monit. How did you verify/test it? Existing kvm test verifies the sanity and new test path. Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Approach What is the motivation for this PR? Enable frr_bmp in mgmt test, also added test case for covering monit log checking. How did you do it? Add golden_config overwrite for frr_bmp, add test case into monit. How did you verify/test it? Existing kvm test verifies the sanity and new test path. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Approach What is the motivation for this PR? Enable frr_bmp in mgmt test, also added test case for covering monit log checking. How did you do it? Add golden_config overwrite for frr_bmp, add test case into monit. How did you verify/test it? Existing kvm test verifies the sanity and new test path. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Contributor
|
Backport 202509: Azure/sonic-mgmt.msft#1059 |
lizhijianrd
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Mar 11, 2026
Cherry-pick of sonic-net/sonic-mgmt#18346 to 202509 branch. **Original PR:** sonic-net/sonic-mgmt#18346 **Author:** @FengPan-Frank ### Why frr_bmp is not a real container - it is a feature switch that tells bgpd to start with BMP module. Tests that iterate enabled features and run docker exec on them fail because there is no frr_bmp container. ### Changes - Skip frr_bmp in test_pretest.py::test_disable_rsyslog_rate_limit - Add frr_bmp golden config overwrite in generate_golden_config_db.py - Add check_version_for_bmp handling in sonic.py and dut_utils.py - Add monit test coverage for frr_bmp ### Verified Tested on Nokia-7215-A1-MGX-G48S4 (testbed-bjw3-can-7215a1d-1), test_disable_rsyslog_rate_limit passes with this fix. Signed-off-by: Zhijian Li <zhijianli@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Enable frr_bmp in mgmt test, also added test case for covering monit log checking.
How did you do it?
Add golden_config overwrite for frr_bmp, add test case into monit.
How did you verify/test it?
Existing kvm test verifies the sanity and new test path.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation