Skip to content

[Mellanox] Remove the skip/xfail for the dualtor_io link failure test#18276

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
congh-nvidia:remove_dualtor_skip
May 20, 2025
Merged

[Mellanox] Remove the skip/xfail for the dualtor_io link failure test#18276
bingwang-ms merged 1 commit intosonic-net:masterfrom
congh-nvidia:remove_dualtor_skip

Conversation

@congh-nvidia
Copy link
Copy Markdown
Contributor

Description of PR

Summary:

  1. Issue #16161 is fixed.
  2. Some test cases that were failing in active-standby due to issue Test cases in dualtor_io/test_link_failure.py fails on Nvidia platforms due to the flooding packets are counted as duplications #8272 have been passing in active-active. Only test_active_link_down_downstream_active_soc[active-active] is still failing.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Issue sonic-net#16161 is fixed.
And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active.
Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.
@congh-nvidia congh-nvidia force-pushed the remove_dualtor_skip branch from 96b91da to 9835dd3 Compare May 20, 2025 02:31
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@congh-nvidia
Copy link
Copy Markdown
Contributor Author

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms merged commit d9c1e25 into sonic-net:master May 20, 2025
14 of 19 checks passed
@mssonicbld
Copy link
Copy Markdown
Collaborator

@congh-nvidia PR conflicts with 202411 branch

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request May 27, 2025
…#18276)

Issue sonic-net#16161 is fixed.
And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active.
Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #18646

mssonicbld pushed a commit that referenced this pull request May 27, 2025
Issue #16161 is fixed.
And some test cases that were failing in active-standby due to issue #8272 have been passing in active-active.
Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.
@congh-nvidia
Copy link
Copy Markdown
Contributor Author

@congh-nvidia PR conflicts with 202411 branch

Manually cherry-picked to 202411: #18712

opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…#18276)

Issue sonic-net#16161 is fixed.
And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active.
Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
…#18276)

Issue sonic-net#16161 is fixed.
And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active.
Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.

Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…#18276)

Issue sonic-net#16161 is fixed.
And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active.
Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…#18276)

Issue sonic-net#16161 is fixed.
And some test cases that were failing in active-standby due to issue sonic-net#8272 have been passing in active-active.
Only test_active_link_down_downstream_active_soc[active-active] is still failing, but the behavior is not exactly the same as active-standby. Probably we need to debug the failure again in active-active scenario.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants