Skip to content

correct telemetry certs creation to include subject name#1825

Merged
daall merged 3 commits intosonic-net:masterfrom
pra-moh:deploy_mg_correct_certs
Jul 1, 2020
Merged

correct telemetry certs creation to include subject name#1825
daall merged 3 commits intosonic-net:masterfrom
pra-moh:deploy_mg_correct_certs

Conversation

@pra-moh
Copy link
Copy Markdown
Contributor

@pra-moh pra-moh commented Jun 27, 2020 •
edited by neethajohn
Loading

Description of PR

Correcting cert creation to include subject name
Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

deploy-mg step is successful on vstestbed

PLAY RECAP ********************************************************************************************************************************************************************************************************
vlab-01                    : ok=36   changed=8    unreachable=0    failed=0    skipped=13   rescued=0    ignored=0   

Saturday 27 June 2020  01:15:15 +0000 (0:00:01.031)       0:01:25.234 ********* 
=============================================================================== 
execute cli "config load_minigraph -y" to apply new minigraph --------------------------------------------------------------------------------------------------------------------------------------------- 74.14s
/var/pramoh/sonic-mgmt/ansible/config_sonic_basedon_testbed.yml:291 ----------------------------------------------------------------------------------------------------------------------------------------------
find interface name mapping and individual interface speed if defined -------------------------------------------------------------------------------------------------------------------------------------- 1.66s
/var/pramoh/sonic-mgmt/ansible/config_sonic_basedon_testbed.yml:83 -----------------------------------------------------------------------------------------------------------------------------------------------
execute cli "config save -y" to save current minigraph as startup-config ----------------------------------------------------------------------------------------------------------------------------------- 1.03s
/var/pramoh/sonic-mgmt/ansible/config_sonic_basedon_testbed.yml:304 ----------------------------------------------------------------------------------------------------------------------------------------------
create new minigraph file for SONiC device ----------------------------------------------------------------------------------------------------------------------------------------------------------------- 0.88s
/var/pramoh/sonic-mgmt/ansible/config_sonic_basedon_testbed.yml:194 ----------------------------------------------------------------------------------------------------------------------------------------------
execute cli "config bgp startup all" to bring up all bgp sessions for test --------------------------------------------------------------------------------------------------------------------------------- 0.64s
/var/pramoh/sonic-mgmt/ansible/config_sonic_basedon_testbed.yml:295 ----------------------------------------------------------------------------------------------------------------------------------------------
Generate dsmsroot cert using openssl. This need to be copied and renamed as streamingtelemetryclient.cer on ptfdocker -------------------------------------------------------------------------------------- 0.63s
/var/pramoh/sonic-mgmt/ansible/config_sonic_basedon_testbed.yml:177 ----------------------------------------------------------------------------------------------------------------------------------------------
Generate server cert using openssl. This need to be copied and renamed as dsmsroot.cer on ptfdocker -------------------------------------------------------------------------------------------------------- 0.46s
/var/pramoh/sonic-mgmt/ansible/config_sonic_basedon_testbed.yml:166 ----------------------------------------------------------------------------------------------------------------------------------------------
Gathering testbed information ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 0.44s

Certs on duT:

dmin@vlab-01:/etc/sonic/telemetry$ ls -l
total 16
-rw-r--r-- 1 root root 1135 Jun 26 22:56 dsmsroot.cer
-rw------- 1 root root 1704 Jun 26 22:56 dsmsroot.key
-rw-r--r-- 1 root root 1135 Jun 26 22:56 streamingtelemetryserver.cer
-rw------- 1 root root 1704 Jun 26 22:56 streamingtelemetryserver.key

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@daall
Copy link
Copy Markdown
Contributor

daall commented Jun 29, 2020

retest vsimage please

daall
daall reviewed Jun 29, 2020
View reviewed changes
hui-ma
hui-ma reviewed Jun 30, 2020
View reviewed changes
ansible/config_sonic_basedon_testbed.yml Outdated
subject:
commonName: ndastreamingclienttest
provider: selfsigned
- name: Generate dsmsroot cert using openssl. This need to be copied and renamed as streamingtelemetryclient.cer on ptfdocker
Copy link
Copy Markdown

@hui-ma hui-ma Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add "dsmsroot_key needs to be copied to renamed as streamingtelemetryclient.key on ptfdocker"

Copy link
Copy Markdown
Contributor Author

@pra-moh pra-moh Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment to both. Let me know if it's not clear. Thanks

@daall daall merged commit 9293f9e into sonic-net:master Jul 1, 2020
@abdosi
Copy link
Copy Markdown
Contributor

abdosi commented Aug 24, 2020

@prsunny Telemetry certs deployed here.

abdosi added a commit to abdosi/sonic-mgmt that referenced this pull request Aug 28, 2020
@abdosi
Ported master PR sonic-net#1825
44544d3 
for internal-201811 so that we can run 209111 image using
anisble-playbook.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi abdosi mentioned this pull request Aug 28, 2020
Merged
abdosi added a commit that referenced this pull request Aug 31, 2020
@abdosi
Ported master PR #1825 (#2157)
8e76bfb 
for internal-201811 so that we can run 209111 image using
anisble-playbook.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@vdahiya12
[202012][sonic-utilities] submodule update (sonic-net#9023)
f63e3cd 
8768089 (HEAD -> 202012, origin/202012) Remove exec from platform_reboot_plugin call to handle any hang issue. (sonic-net#1879)
ae5d90c Validate input of ```config mirror_session add``` (sonic-net#1825)
44d3a3b [show][config] fix the muxcable commands for interface naming mode (sonic-net#1862)
0a4933e [TH3] Skipp Control Plane Assist on WARM Reboot for TH3 HWSKUs (sonic-net#1861)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hui-ma hui-ma hui-ma approved these changes

@daall daall daall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug 🐛 Jenkins-Pilot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pra-moh @daall @abdosi @hui-ma