Adjust port selection in testQosSaiXonHysteresis for Cisco-8101-O32 by zhixzhu · Pull Request #18130 · sonic-net/sonic-mgmt

zhixzhu · 2025-04-25T23:47:34Z

Description of PR

Summary:
Fixes # (issue)
https://migsonic.atlassian.net/browse/MIGSMSFT-848
qos.test_qos_sai.TestQosSai.testQosSaiXonHysteresis failed on hwsku Cisco-8101-O32 T1 setup.
VOQ tail drop since connected routes use default voq. Multi src_ports → same dst_port using same voq, caused voq tail drop happen before PFC triggered.

Type of change

Back port request

Approach

What is the motivation for this PR?

Fix testQosSaiXonHysteresis failures for Cisco-8101-O32.

How did you do it?

Adjust port selection to avoid multiple flows using same voq.

How did you verify/test it?

Verified on Cisco-8101-O8C48 T1 testbed.
SONiC Software Version: SONiC.azure_cisco_202411.23036-dirty-20250402.193037
sdk-version: 24.11.3000.24

-------------- generated xml file: /tmp/qos/test_qos_sai.py::TestQosSai::testQosSaiXonHysteresis_2025-04-25-23-19-16.xml --------------
INFO:root:Can not get Allure report URL. Please check logs
------------------------------------------------------- live log sessionfinish --------------------------------------------------------
23:32:17 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
======================================================= short test summary info =======================================================
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiXonHysteresis[single_asic-xon_hysteresis_1]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiXonHysteresis[single_asic-xon_hysteresis_2]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiXonHysteresis[single_asic-xon_hysteresis_3]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiXonHysteresis[single_asic-xon_hysteresis_4]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiXonHysteresis[single_asic-xon_hysteresis_5]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiXonHysteresis[single_asic-xon_hysteresis_6]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiXonHysteresis[single_asic-xon_hysteresis_7]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiXonHysteresis[single_asic-xon_hysteresis_8]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiXonHysteresis[single_asic-xon_hysteresis_9]
SKIPPED [9] qos/test_qos_sai.py:2499: Did not find any frontend node that is multi-asic - so can't run single_dut_multi_asic tests
SKIPPED [27] qos/test_qos_sai.py:2499: multi-dut is not supported on T1 topologies
======================================== 9 passed, 36 skipped, 1 warning in 780.42s (0:13:00) =========================================
sonic@sonic-ucs-m6-26:/data/tests$

Any platform specific information?

For HwSKU: Cisco-8101-

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-04-25T23:47:41Z

/azp run

azure-pipelines · 2025-04-25T23:47:52Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>

mssonicbld · 2025-04-25T23:57:45Z

/azp run

azure-pipelines · 2025-04-25T23:57:55Z

Azure Pipelines successfully started running 1 pipeline(s).

wsycqyz

Verified on MSFT internal lab and looks good.

kevinskwang · 2025-04-27T06:27:39Z

@zhixzhu I didn't fully understand "VOQ tail drop since connected routes use default voq", could you explain more?

…onic-net#18130) Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>

mssonicbld · 2025-04-27T06:29:36Z

Cherry-pick PR to 202411: #18135

…18130) Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>

Code sync sonic-net/sonic-mgmt:202411 => 202412 ``` * | c6a94a0 (pub_upstream/202411) Revert "[dualtor_io] Allow duplications for link down downstream I/O (sonic-net#17909)" (sonic-net#18192) * | de454d5 [testARPCompleted] Cleanup ptf ip after test failure (sonic-net#18170) * | 4a3d1d9 [dualtor] Refine `fdb_mac_learning_test.py` (sonic-net#18092) * | 5964a78 [dualtor_io] Fix the start marker not found issue (sonic-net#18096) * | ce40816 Extend LACP time multiplier for advanced-reboot tests with cEOS peers (sonic-net#17964) * | 0e70ba3 adjust port selection in case testQosSaiXonHysteresis for Cisco-8101 (sonic-net#18130) * | 8bb7203 [202411] Restore disable packet aging fixture 202411 (sonic-net#18103) * | 8f6d1a3 Filter out Not Applicable values in command line (sonic-net#18006) * | 9d5de5c Backport t0-118 test configs to 202411 (sonic-net#17983) ```

Code sync sonic-net/sonic-mgmt:202411 => 202503 ``` * 6b59eaa (HEAD -> sync/202503, origin/sync/202503) Merge remote-tracking branch 'pub_upstream/202411' into sync/202503 |\ | * c6a94a0 (pub_upstream/202411) Revert "[dualtor_io] Allow duplications for link down downstream I/O (sonic-net#17909)" (sonic-net#18192) | * de454d5 [testARPCompleted] Cleanup ptf ip after test failure (sonic-net#18170) | * 4a3d1d9 [dualtor] Refine `fdb_mac_learning_test.py` (sonic-net#18092) | * 5964a78 [dualtor_io] Fix the start marker not found issue (sonic-net#18096) | * ce40816 Extend LACP time multiplier for advanced-reboot tests with cEOS peers (sonic-net#17964) | * 0e70ba3 adjust port selection in case testQosSaiXonHysteresis for Cisco-8101 (sonic-net#18130) | * 8bb7203 [202411] Restore disable packet aging fixture 202411 (sonic-net#18103) | * 8f6d1a3 Filter out Not Applicable values in command line (sonic-net#18006) | * 9d5de5c Backport t0-118 test configs to 202411 (sonic-net#17983) | * e758401 mark xfail on generic hash test for isolated topo (sonic-net#18071) | * c65ceab [202411][dualtor] Skip pfcwd warm reboot on dualtor (sonic-net#18072) | * c509006 Improve disabling packet aging to support swap_syncd (sonic-net#17728) (sonic-net#17739) | * 9dc2244 [202411][dualtor-aa] Fix test_arp_dualtor on active-active dualtor (sonic-net#18073) | * cf12a33 fixed tacacs duplicate user issue (sonic-net#18068) | * 330a893 Fix telemetry/test_events.py for dualtor (sonic-net#18025) | * dc6fee8 Remove admin down ports in BUFFER PG check logic (sonic-net#17505) | * 805d538 Update generic hash test to support dualtor active active topology (sonic-net#16217) | * 7c31e46 [dualtor_io] Allow duplications for link down downstream I/O (sonic-net#17909) | * a7f50c6 Fix vlan vs router mac issue with test_qos_dscp_mapping.py (sonic-net#17846) (sonic-net#18003) | * 9ab1e7a Skip test_incremental_qos on Mellanox dualtor (sonic-net#17406) (sonic-net#18048) | * f42afd0 Force eos default creds to be string (sonic-net#18026) | * be542b0 Restore config after vxlan_crm from vxlan_ecmp. (sonic-net#17767) | * f0718b9 [Fix for Issue sonic-net#17413] Modified the Tx Rx port id list selection for all to all scenario (sonic-net#17919) | * 3eb4ed4 [dualtor_io] Collect syslog to debug (sonic-net#17722) | * d5bd995 Disable PFC-WD during PCBB and some wmk test improvements (sonic-net#17889) | * 2f512aa Update outer UDP sport range to exclude port 53 (sonic-net#17570) (sonic-net#17798) | * 980b373 skip test_bgp_slb advanced reboot for isolated topo (sonic-net#17470) | * 408bf9e Default the inner dscp to outer dscp map to be 1-1. (sonic-net#17860) | * 37495a1 Add dualtor fixtures to no_traffic test. (sonic-net#17916) | * a13b599 Only print the matched syslog in loganalzyer teardown check, no traceback info printed (sonic-net#17926) | * 6127f29 Revert "Skip test_vnet_decap on Cisco-8000 with 202411 (sonic-net#17776)" (sonic-net#17941) (sonic-net#17942) | * 60274db Increase timeout to 5 in verify_packet_any_port for background traffic (sonic-net#17904) ```

…onic-net#18130) Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>

…onic-net#18130) Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

zhixzhu changed the title ~~adjust port selection in case testQosSaiXonHysteresis for Cisco-8101-O32~~ Adjust port selection in case testQosSaiXonHysteresis for Cisco-8101-O32 Apr 25, 2025

adjust port selection in case testQosSaiXonHysteresis for Cisco-8101

945b171

Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>

zhixzhu force-pushed the XonHysteresis branch from f03d9f7 to 945b171 Compare April 25, 2025 23:57

zhixzhu changed the title ~~Adjust port selection in case testQosSaiXonHysteresis for Cisco-8101-O32~~ Adjust port selection in testQosSaiXonHysteresis for Cisco-8101-O32 Apr 25, 2025

wsycqyz added the Request for 202411 branch label Apr 27, 2025

wsycqyz approved these changes Apr 27, 2025

View reviewed changes

kevinskwang approved these changes Apr 27, 2025

View reviewed changes

kevinskwang merged commit fb73b48 into sonic-net:master Apr 27, 2025
15 checks passed

kevinskwang added the Approved for 202411 branch label Apr 27, 2025

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Apr 27, 2025

adjust port selection in case testQosSaiXonHysteresis for Cisco-8101 (s…

ae14015

…onic-net#18130) Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>

mssonicbld added the Created PR to 202411 branch label Apr 27, 2025

mssonicbld mentioned this pull request Apr 27, 2025

[action] [PR:18130] Adjust port selection in testQosSaiXonHysteresis for Cisco-8101-O32 #18135

Merged

11 tasks

mssonicbld pushed a commit that referenced this pull request Apr 28, 2025

adjust port selection in case testQosSaiXonHysteresis for Cisco-8101 (#…

0e70ba3

…18130) Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>

mssonicbld added Included in 202411 branch and removed Created PR to 202411 branch labels Apr 28, 2025

zhixzhu deleted the XonHysteresis branch April 28, 2025 16:58

opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025

adjust port selection in case testQosSaiXonHysteresis for Cisco-8101 (s…

f606607

…onic-net#18130) Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>

gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025

adjust port selection in case testQosSaiXonHysteresis for Cisco-8101 (s…

3e3bf34

…onic-net#18130) Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026

adjust port selection in case testQosSaiXonHysteresis for Cisco-8101 (s…

8707f15

…onic-net#18130) Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adjust port selection in testQosSaiXonHysteresis for Cisco-8101-O32#18130

Adjust port selection in testQosSaiXonHysteresis for Cisco-8101-O32#18130
kevinskwang merged 1 commit intosonic-net:masterfrom
zhixzhu:XonHysteresis

zhixzhu commented Apr 25, 2025

Uh oh!

mssonicbld commented Apr 25, 2025

Uh oh!

azure-pipelines Bot commented Apr 25, 2025

Uh oh!

mssonicbld commented Apr 25, 2025

Uh oh!

azure-pipelines Bot commented Apr 25, 2025

Uh oh!

wsycqyz left a comment

Uh oh!

kevinskwang commented Apr 27, 2025

Uh oh!

Uh oh!

mssonicbld commented Apr 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

zhixzhu commented Apr 25, 2025

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Apr 25, 2025

Uh oh!

azure-pipelines Bot commented Apr 25, 2025

Uh oh!

mssonicbld commented Apr 25, 2025

Uh oh!

azure-pipelines Bot commented Apr 25, 2025

Uh oh!

wsycqyz left a comment

Choose a reason for hiding this comment

Uh oh!

kevinskwang commented Apr 27, 2025

Uh oh!

Uh oh!

mssonicbld commented Apr 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants