[device] get attributes from super class when unavailabe#1811
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jun 24, 2020
Merged
[device] get attributes from super class when unavailabe#1811yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
|
This pull request introduces 1 alert when merging 69ad86f into bfea307 - view on LGTM.com new alerts:
|
wangxin
approved these changes
Jun 24, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…t#8778) 912d443 [sonic-utilities]remove db_migrator logic for autoneg enable/disable (sonic-net#1823) 5323e9d [202012] Advertise ipv6 link local address (sonic-net#1811) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
test_link_flap failing with following output:
platform_tests/test_link_flap.py:81:
platform_tests/test_link_flap.py:63: in run_link_flap_test
candidates = self.__build_test_candidates(dut, fanouthosts)
platform_tests/test_link_flap.py:50: in __build_test_candidates
if not fanout or not fanout_port:
common/devices.py:883: in getattr
return getattr(self.host, module_name)
common/devices.py:708: in getattr
return super(EosHost, self).getattr(module_name)
self = <tests.common.devices.EosHost object at 0x7f0083050750>, module_name = 'nonzero'
E UnsupportedAnsibleModule: Unsupported module
module_name = 'nonzero'
self = <tests.common.devices.EosHost object at 0x7f0083050750>
common/devices.py:56: UnsupportedAnsibleModule
How did you do it?
Call super class to return attributes when unavailable.
How did you verify/test it?
With the fix. test_link_flap passes:
plugins: ansible-2.2.2, xdist-1.28.0, forked-1.1.3, repeat-0.8.0
collected 1 item
platform_tests/test_link_flap.py::test_link_flap PASSED [100%]