[dualtor] Skip pfcwd warm reboot on dualtor#18031
Merged
yxieca merged 1 commit intosonic-net:masterfrom Apr 18, 2025
Merged
Conversation
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lipxu
approved these changes
Apr 17, 2025
| conditions: | ||
| - "'dualtor' in topo_name" | ||
| - https://github.com/sonic-net/sonic-mgmt/issues/8400 | ||
| - "'dualtor' in topo_name and https://github.com/sonic-net/sonic-mgmt/issues/8400" |
Contributor
There was a problem hiding this comment.
We want to use skip instead of xfail here, is it because the case itself would cause the environment issue? If it is, maybe we should consider to enhance the case in the further.
Collaborator
Author
There was a problem hiding this comment.
yes, warm-reboot is not fully verified on dualtor that it might cause dataplane inconsistency.
Collaborator
|
@lolyu PR conflicts with 202411 branch |
11 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Apr 23, 2025
What is the motivation for this PR? Cherry-pick #18031 into 202411 Signed-off-by: Longxiang Lyu lolv@microsoft.com
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
What is the motivation for this PR? Warm reboot is not fully-supported on dualtor, and might leave the testbed in a corrupted state. Let's skip the pfc wb testcase for now. How did you do it? Skip the pfcwd warm reboot test on dualtor. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? Warm reboot is not fully-supported on dualtor, and might leave the testbed in a corrupted state. Let's skip the pfc wb testcase for now. How did you do it? Skip the pfcwd warm reboot test on dualtor. Signed-off-by: Longxiang Lyu <lolv@microsoft.com> Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
What is the motivation for this PR? Warm reboot is not fully-supported on dualtor, and might leave the testbed in a corrupted state. Let's skip the pfc wb testcase for now. How did you do it? Skip the pfcwd warm reboot test on dualtor. Signed-off-by: Longxiang Lyu <lolv@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
What is the motivation for this PR? Warm reboot is not fully-supported on dualtor, and might leave the testbed in a corrupted state. Let's skip the pfc wb testcase for now. How did you do it? Skip the pfcwd warm reboot test on dualtor. Signed-off-by: Longxiang Lyu <lolv@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Warm reboot is not fully-supported on dualtor, and might leave the testbed in a corrupted state.
Let's skip the pfc wb testcase for now.
Signed-off-by: Longxiang Lyu lolv@microsoft.com
How did you do it?
Skip the pfcwd warm reboot test on dualtor.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation