[ixia/Keysight] Initialized user & pswd variables#1802
Closed
abhijit-dhar wants to merge 1 commit intosonic-net:masterfrom
abhijit-dhar:master
Closed
[ixia/Keysight] Initialized user & pswd variables#1802abhijit-dhar wants to merge 1 commit intosonic-net:masterfrom abhijit-dhar:master
abhijit-dhar wants to merge 1 commit intosonic-net:masterfrom
abhijit-dhar:master
Conversation
[ixia/Keysight] Note that if these variables 'user' and 'pswd' are not initialized, they will encounter an exception after the following code fragment, when control does not enter if/else part (reason variable not defined).
if os_type == "eos":
:
elif os_type == "onyx":
:
I got this exception while adopting the fanouthosts fixture. Ixia chassis do not require user / pswd.
|
This pull request introduces 2 alerts when merging cf6a2cc into 8e946c6 - view on LGTM.com new alerts:
|
Contributor
Author
|
My file was older one. I saw a lot of changes has been made in this file, including this fixture |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[vlanmgr]Fix for STATE_DB port check logic (sonic-net#1980) Update sonic-utilities submodule 434c2fb [sonic-package-manager] update FEATURE entries on upgrade (sonic-net#1803) d1ca400 [sonic-package-manager] code style fixes and enhancements (sonic-net#1802)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ixia/Keysight] Note that if these variables 'user' and 'pswd' are not initialized, they will encounter an exception after the following code fragment, when control does not enter if/else part (reason variable not defined).
if os_type == "eos":
:
elif os_type == "onyx":
:
I got this exception while adopting the fanouthosts fixture. Ixia chassis do not require user / pswd.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation