feat: support skipping iBGP check in reboot/reload#17477
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Mar 31, 2025
Merged
feat: support skipping iBGP check in reboot/reload#17477yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adc78ae to
b3880d9
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
amulyan7
pushed a commit
to amulyan7/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
Description of PR Add option to skip iBGP check during health check after reboot and reload Summary: Fixes # (issue) Microsoft ADO 30056122 Approach What is the motivation for this PR? Sometimes we do not want to wait for iBGP to be up after reboot and reload as it's not related to our test and it's stopping us from utilizing the parallel run infrastructure. After adding this option, we can skip the iBGP check during health check after reboot and reload, so we can parallel run some test modules (e.g. pc/test_po_cleanup.py). After the test module is done, we can enable post-test sanity check to wait for all the BGP sessions (eBGP & iBGP) to be up before starting the next module. How did you do it? How did you verify/test it? I ran the updated code and can confirm it's working well. co-authorized by: jianquanye@microsoft.com
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
Description of PR Add option to skip iBGP check during health check after reboot and reload Summary: Fixes # (issue) Microsoft ADO 30056122 Approach What is the motivation for this PR? Sometimes we do not want to wait for iBGP to be up after reboot and reload as it's not related to our test and it's stopping us from utilizing the parallel run infrastructure. After adding this option, we can skip the iBGP check during health check after reboot and reload, so we can parallel run some test modules (e.g. pc/test_po_cleanup.py). After the test module is done, we can enable post-test sanity check to wait for all the BGP sessions (eBGP & iBGP) to be up before starting the next module. How did you do it? How did you verify/test it? I ran the updated code and can confirm it's working well. co-authorized by: jianquanye@microsoft.com
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
Description of PR Add option to skip iBGP check during health check after reboot and reload Summary: Fixes # (issue) Microsoft ADO 30056122 Approach What is the motivation for this PR? Sometimes we do not want to wait for iBGP to be up after reboot and reload as it's not related to our test and it's stopping us from utilizing the parallel run infrastructure. After adding this option, we can skip the iBGP check during health check after reboot and reload, so we can parallel run some test modules (e.g. pc/test_po_cleanup.py). After the test module is done, we can enable post-test sanity check to wait for all the BGP sessions (eBGP & iBGP) to be up before starting the next module. How did you do it? How did you verify/test it? I ran the updated code and can confirm it's working well. co-authorized by: jianquanye@microsoft.com
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Description of PR Add option to skip iBGP check during health check after reboot and reload Summary: Fixes # (issue) Microsoft ADO 30056122 Approach What is the motivation for this PR? Sometimes we do not want to wait for iBGP to be up after reboot and reload as it's not related to our test and it's stopping us from utilizing the parallel run infrastructure. After adding this option, we can skip the iBGP check during health check after reboot and reload, so we can parallel run some test modules (e.g. pc/test_po_cleanup.py). After the test module is done, we can enable post-test sanity check to wait for all the BGP sessions (eBGP & iBGP) to be up before starting the next module. How did you do it? How did you verify/test it? I ran the updated code and can confirm it's working well. co-authorized by: jianquanye@microsoft.com Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Description of PR Add option to skip iBGP check during health check after reboot and reload Summary: Fixes # (issue) Microsoft ADO 30056122 Approach What is the motivation for this PR? Sometimes we do not want to wait for iBGP to be up after reboot and reload as it's not related to our test and it's stopping us from utilizing the parallel run infrastructure. After adding this option, we can skip the iBGP check during health check after reboot and reload, so we can parallel run some test modules (e.g. pc/test_po_cleanup.py). After the test module is done, we can enable post-test sanity check to wait for all the BGP sessions (eBGP & iBGP) to be up before starting the next module. How did you do it? How did you verify/test it? I ran the updated code and can confirm it's working well. co-authorized by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Description of PR Add option to skip iBGP check during health check after reboot and reload Summary: Fixes # (issue) Microsoft ADO 30056122 Approach What is the motivation for this PR? Sometimes we do not want to wait for iBGP to be up after reboot and reload as it's not related to our test and it's stopping us from utilizing the parallel run infrastructure. After adding this option, we can skip the iBGP check during health check after reboot and reload, so we can parallel run some test modules (e.g. pc/test_po_cleanup.py). After the test module is done, we can enable post-test sanity check to wait for all the BGP sessions (eBGP & iBGP) to be up before starting the next module. How did you do it? How did you verify/test it? I ran the updated code and can confirm it's working well. co-authorized by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Add option to skip iBGP check during health check after reboot and reload
Summary:
Fixes # (issue) Microsoft ADO 30056122
Type of change
Back port request
Approach
What is the motivation for this PR?
Sometimes we do not want to wait for iBGP to be up after reboot and reload as it's not related to our test and it's stopping us from utilizing the parallel run infrastructure. After adding this option, we can skip the iBGP check during health check after reboot and reload, so we can parallel run some test modules (e.g.
pc/test_po_cleanup.py). After the test module is done, we can enable post-test sanity check to wait for all the BGP sessions (eBGP & iBGP) to be up before starting the next module.How did you do it?
How did you verify/test it?
I ran the updated code and can confirm it's working well.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation