[Mellanox] Fix dip_sip test bug - added support for portchannels that consist of more than one interface#1685
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom May 20, 2020
Conversation
liat-grozovik
approved these changes
May 19, 2020
Collaborator
|
@noaOrMlnx can you please update the commit header and have it related to sip dip test? |
Contributor
|
what is portchannel splits? |
Contributor
Author
@lguohan Before the change, the packet was expected to arrive only to the first interface (here, Ethernet0), even though it can arrive on any of them. |
Collaborator
|
@noaOrMlnx please clarify that in the commit description. the concept of portchannel split is not work. suggest you use portchannel with multiple ports. |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…onic-net#7313) sonic-swss * Don't update pools when ingress_lossless_pool is created but the initialization hasn't finished yet (sonic-net#1685) * Fix dynamic buffer bug occuring in rare condition (sonic-net#1678) sonic-utilities * [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552) Signed-off-by: Danny Allen <daall@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
Changed lag_facts function to support portchannels that consists of more than one interface.
After the change, the received packet is expected to arrive to any of those interfaces.
How did you verify/test it?
Run dip sip test with lag topology (t0/t1-lag).
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation