Skip to content

Added support of Onyx based fanout in 'fanouthosts' fixture#1674

Merged
yxieca merged 7 commits intosonic-net:masterfrom
yvolynets-mlnx:pr_onyx_fanout_support
Jun 2, 2020
Merged

Added support of Onyx based fanout in 'fanouthosts' fixture#1674
yxieca merged 7 commits intosonic-net:masterfrom
yvolynets-mlnx:pr_onyx_fanout_support

Conversation

@yvolynets-mlnx
Copy link
Copy Markdown
Contributor

@yvolynets-mlnx yvolynets-mlnx commented May 14, 2020

Description of PR

Summary: Added support of Onyx OS based fanout for 'fanouthosts' fixture
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

Extended 'fanouthosts' fixture with newly created class 'OnyxHost' which transport is based on onyx_config and onyx_command ansible modules.
Also added extended possibility to execute any playbook via fanout instance - for workaround cases when some actions can't be executed via available transport.

How did you verify/test it?

Tested on the local setup with PFC Asymmetric test cases.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented May 14, 2020

This pull request introduces 1 alert when merging a94301d into f11d076 - view on LGTM.com

new alerts:

  • 1 for Module is imported more than once

yvolynets-mlnx added a commit to yvolynets-mlnx/sonic-mgmt that referenced this pull request May 14, 2020
* Created separate PR which adds support of Onyx OS based fanout - sonic-net#1674
Comment thread ansible/group_vars/all/inv_mapping.json Outdated
Comment thread tests/common/fixtures/conn_graph_facts.py Outdated
@neethajohn neethajohn requested a review from yxieca May 14, 2020 15:33
@yvolynets-mlnx
Copy link
Copy Markdown
Contributor Author

yvolynets-mlnx commented May 15, 2020

This pull request introduces 1 alert when merging a94301d into f11d076 - view on LGTM.com

new alerts:

* 1 for Module is imported more than once

Will be fixed.

Comment thread tests/common/devices.py
yvolynets-mlnx and others added 3 commits May 25, 2020 15:07
… fixture

Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>
Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented May 25, 2020

This pull request introduces 1 alert when merging 0bc3790 into d79d500 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

Comment thread ansible/group_vars/all/inv_mapping.yml Outdated
Comment thread ansible/group_vars/all/inv_mapping.yml Outdated
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented May 25, 2020

This pull request introduces 1 alert when merging 9d8ef0d into d79d500 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

@yvolynets-mlnx
Copy link
Copy Markdown
Contributor Author

This pull request introduces 1 alert when merging a94301d into f11d076 - view on LGTM.com
new alerts:

* 1 for Module is imported more than once

Will be fixed.

Fixed

Comment thread tests/common/devices.py Outdated
Comment thread tests/common/devices.py Outdated
Comment thread tests/common/fixtures/conn_graph_facts.py Outdated
Comment thread tests/conftest.py Outdated
Comment thread tests/common/fixtures/conn_graph_facts.py
Comment thread ansible/group_vars/all/inv_mapping.yml Outdated
Signed-off-by: Yuriy Volynets <yuriyv@mellanox.com>
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented May 29, 2020

This pull request introduces 1 alert when merging cf9e47c into 52a7d94 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

@yvolynets-mlnx
Copy link
Copy Markdown
Contributor Author

@neethajohn @wangxin Would be nice to checkthis PR and merge, because #1534 is blocked

@qiluo-msft
Copy link
Copy Markdown
Contributor

Could you fix the LGTM new alert?

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Jun 2, 2020

This pull request introduces 1 alert when merging 0663ba4 into 0c018b1 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

@yxieca yxieca merged commit 23e36cf into sonic-net:master Jun 2, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
utilities:
* 83f068b 2021-03-22 | Handling error scenario of adding port to Vlan which is part of LAG (sonic-net#1516) (HEAD -> 202012) [Sudharsan Dhamal Gopalarathnam]
* 470e8ce 2021-03-24 | Enable PFCWD only on ports where PFC is enabled (sonic-net#1508) [Andriy Yurkiv]
* 09ef2e0 2021-03-22 | [show][config] add support for setting and displaying switching modes on Y cable (sonic-net#1501) [vdahiya12]
* 0d17d37 2021-03-24 | Warmboot script improvements - timeout exec, disable swss autorestart, remove trap (sonic-net#1495) [Vaibhav Hemant Dixit]
* 2718cd8 2021-03-24 | [show] Fix int status of LAGs, configured as Vlan members (sonic-net#1478) [maksymbelei95]
* cc168fb 2021-03-22 | Fix bug: show vlan config for vlan with no members (sonic-net#1503) [allas-nvidia]

swss:
* 5d8d1fb 2021-03-26 | Revert "Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)" (sonic-net#1682) (HEAD -> 202012) [Prince Sunny]
* f8df1f8 2021-03-26 | [Dynamic Buffer Calc] Enhance the field checking in table handling (sonic-net#1680) [Stephen Sun]
* 6328c9f 2021-03-22 | [MuxOrch] FDB ageout safety check (sonic-net#1674) [Prince Sunny]
* e1d733e 2021-03-21 | reduce severity of log to info in case of flush on non-existing member (sonic-net#1669) [allas-nvidia]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants