Add tgen_port_info to dynamically adjust multidut_port_info fixture by auspham · Pull Request #16729 · sonic-net/sonic-mgmt

auspham · 2025-01-30T09:02:02Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-01-30T09:02:05Z

/azp run

azure-pipelines · 2025-01-30T09:02:22Z

Azure Pipelines successfully started running 1 pipeline(s).

auspham · 2025-01-30T09:06:36Z

@sdszhang verified on T2 that we can create fixture

On T0 i have skipped for unknown port, could be my local environment not working

To make this work we need to remove all import multidut_port_info as well since we will remove this fixture.

The default value for T0 could be an arbitrary testbed since if we leave it empty it will skip the test.

sdszhang · 2025-01-30T13:00:11Z

@amitpawar12 @vmittal-msft @rraghav-cisco @kamalsahu0001 @selldinesh this could a solution to retrieve ports based on the selected testbed, and remove the dependencies on the constant MULTIDUT_TESTBED.

@abdosi for viz.

mssonicbld · 2025-02-14T04:55:28Z

/azp run

azure-pipelines · 2025-02-14T04:55:40Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-17T00:03:56Z

/azp run

azure-pipelines · 2025-02-17T00:04:08Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-17T00:35:06Z

/azp run

azure-pipelines · 2025-02-17T00:35:18Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-17T03:40:35Z

/azp run

azure-pipelines · 2025-02-17T03:40:46Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-17T04:40:05Z

/azp run

azure-pipelines · 2025-02-17T04:40:16Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-19T23:40:21Z

/azp run

azure-pipelines · 2025-02-19T23:40:33Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-20T00:42:46Z

/azp run

azure-pipelines · 2025-02-20T00:42:57Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-03-19T04:41:47Z

/azp run

azure-pipelines · 2025-03-19T04:41:59Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Austin Pham <austinpham@microsoft.com> chore: update tgen port info Signed-off-by: Austin Pham <austinpham@microsoft.com>

mssonicbld · 2025-03-19T22:55:20Z

/azp run

azure-pipelines · 2025-03-19T22:55:31Z

Azure Pipelines successfully started running 1 pipeline(s).

auspham · 2025-05-06T04:26:31Z

closes in favor of #18067

Description of PR Summary: Fixes # (issue) Type of change After #16729 and #15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown -------------------------------

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown -------------------------------

Description of PR Summary: Fixes # (issue) Type of change After #16729 and #15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown -------------------------------

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown ------------------------------- Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown ------------------------------- Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown -------------------------------

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown ------------------------------- Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

Description of PR Summary: Fixes # (issue) Type of change After sonic-net#16729 and sonic-net#15069, existing test cases need to be updated to support dynamic port selection. Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? Update test case to adopt the new feature How did you do it? How did you verify/test it? snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info0] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|3-tgen_port_info1] PASSED [ 50%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info0] PASSED [ 75%] snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[str3-8800-lc4-1|4-tgen_port_info1] PASSED [100%] ------------------------------ live log teardown ------------------------------- Signed-off-by: Yael Tzur <ytzur@nvidia.com>

auspham force-pushed the austinpham/test-multidut-fixture-dynamic branch from 68550e8 to ee23110 Compare February 14, 2025 04:55

auspham changed the title ~~chore: test variables.py~~ Add dynamic_port_info to dynamically adjust multidut_port_info Feb 16, 2025

auspham changed the title ~~Add dynamic_port_info to dynamically adjust multidut_port_info~~ Add dynamic_port_info to dynamically adjust multidut_port_info fixture Feb 16, 2025

auspham marked this pull request as ready for review February 16, 2025 22:15

sdszhang reviewed Feb 16, 2025

View reviewed changes

Comment thread tests/conftest.py Outdated

sdszhang reviewed Feb 16, 2025

View reviewed changes

Comment thread tests/conftest.py Outdated

auspham force-pushed the austinpham/test-multidut-fixture-dynamic branch from ee23110 to 1d4551d Compare February 17, 2025 00:03

auspham changed the title ~~Add dynamic_port_info to dynamically adjust multidut_port_info fixture~~ Add tgen_port_info to dynamically adjust multidut_port_info fixture Feb 17, 2025

auspham force-pushed the austinpham/test-multidut-fixture-dynamic branch from 1d4551d to 97757d1 Compare February 17, 2025 00:35

auspham force-pushed the austinpham/test-multidut-fixture-dynamic branch from 97757d1 to 9392db3 Compare February 17, 2025 03:40

sdszhang reviewed Feb 17, 2025

View reviewed changes

Comment thread tests/snappi_tests/tgen_port_config.yml Outdated

sdszhang approved these changes Feb 17, 2025

View reviewed changes

auspham force-pushed the austinpham/test-multidut-fixture-dynamic branch from 9392db3 to 2bb8558 Compare February 17, 2025 04:40

sdszhang reviewed Feb 19, 2025

View reviewed changes

Comment thread tests/snappi_tests/tgen_port_config.yml Outdated

sdszhang reviewed Feb 20, 2025

View reviewed changes

Comment thread tests/snappi_tests/tgen_port_config.json Outdated

auspham force-pushed the austinpham/test-multidut-fixture-dynamic branch from 21b615b to 57baa92 Compare February 20, 2025 00:42

sdszhang approved these changes Feb 20, 2025

View reviewed changes

auspham force-pushed the austinpham/test-multidut-fixture-dynamic branch from 57baa92 to 7425219 Compare March 19, 2025 04:41

feat: add fixture tgen_port_info

5d4ac09

Signed-off-by: Austin Pham <austinpham@microsoft.com> chore: update tgen port info Signed-off-by: Austin Pham <austinpham@microsoft.com>

auspham force-pushed the austinpham/test-multidut-fixture-dynamic branch from 7425219 to 5d4ac09 Compare March 19, 2025 22:55

sdszhang added this to SONiC Snappi Mar 21, 2025

sdszhang moved this to In Progress in SONiC Snappi Mar 26, 2025

auspham closed this May 6, 2025

github-project-automation Bot moved this from In Progress to Done in SONiC Snappi May 6, 2025

sdszhang mentioned this pull request May 28, 2025

update test_pfc_pause_lossless_with_snappi.py to use dynamic port selection #18673

Merged

11 tasks

mssonicbld mentioned this pull request Jun 5, 2025

[action] [PR:18673] update test_pfc_pause_lossless_with_snappi.py to use dynamic port selection #18814

Merged

11 tasks

sdszhang mentioned this pull request Mar 27, 2026

Refactor: Enable dynamic port selection from setup in snappi pfcwd test #23366

Closed

Conversation

auspham commented Jan 30, 2025

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Jan 30, 2025

Uh oh!

azure-pipelines Bot commented Jan 30, 2025

Uh oh!

auspham commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sdszhang commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Feb 14, 2025

Uh oh!

azure-pipelines Bot commented Feb 14, 2025

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Feb 17, 2025

Uh oh!

azure-pipelines Bot commented Feb 17, 2025

Uh oh!

mssonicbld commented Feb 17, 2025

Uh oh!

azure-pipelines Bot commented Feb 17, 2025

Uh oh!

mssonicbld commented Feb 17, 2025

Uh oh!

azure-pipelines Bot commented Feb 17, 2025

Uh oh!

Uh oh!

mssonicbld commented Feb 17, 2025

Uh oh!

azure-pipelines Bot commented Feb 17, 2025

Uh oh!

Uh oh!

mssonicbld commented Feb 19, 2025

Uh oh!

azure-pipelines Bot commented Feb 19, 2025

Uh oh!

Uh oh!

mssonicbld commented Feb 20, 2025

Uh oh!

azure-pipelines Bot commented Feb 20, 2025

Uh oh!

mssonicbld commented Mar 19, 2025

Uh oh!

azure-pipelines Bot commented Mar 19, 2025

Uh oh!

mssonicbld commented Mar 19, 2025

Uh oh!

azure-pipelines Bot commented Mar 19, 2025

Uh oh!

auspham commented May 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

auspham commented Jan 30, 2025 •

edited

Loading

sdszhang commented Jan 30, 2025 •

edited

Loading