[fanout connect playbook] Fix variable undefined in rootfanout_connect.yml#16634
Merged
Blueve merged 2 commits intosonic-net:masterfrom Jan 23, 2025
Merged
[fanout connect playbook] Fix variable undefined in rootfanout_connect.yml#16634Blueve merged 2 commits intosonic-net:masterfrom
Blueve merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Blueve
approved these changes
Jan 22, 2025
11 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#25 |
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
…t.yml (sonic-net#16634) Summary: Fixes # (issue) In PR: sonic-net#15643, it add a new optional variable clean_before_add for template arista_7260_connect.j2 to indicate whether clean vlan range before add vlan range, however, this variable are defined in fanout_connect.yml which will call rootfanout_connect.yml, this will be a bug, because when rootfanout_connect.yml is called by other playbook, it will raise error: clean_before_add undefined, so, to fix this bug, we move the clean_before_add definition from fanout_connect.yml to rootfanout_connect.yml. What is the motivation for this PR? this will be a bug, because when rootfanout_connect.yml is called by other playbook, it will raise error: clean_before_add undefined How did you do it? move the clean_before_add definition from fanout_connect.yml to rootfanout_connect.yml. How did you verify/test it? local run playbook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
In PR: #15643, it add a new optional variable
clean_before_addfor templatearista_7260_connect.j2to indicate whether clean vlan range before add vlan range, however, this variable are defined infanout_connect.ymlwhich will callrootfanout_connect.yml, this will be a bug, because whenrootfanout_connect.ymlis called by other playbook, it will raise error: clean_before_add undefined, so, to fix this bug, we move theclean_before_adddefinition fromfanout_connect.ymltorootfanout_connect.yml.Type of change
Back port request
Approach
What is the motivation for this PR?
this will be a bug, because when
rootfanout_connect.ymlis called by other playbook, it will raise error: clean_before_add undefinedHow did you do it?
move the
clean_before_adddefinition fromfanout_connect.ymltorootfanout_connect.yml.How did you verify/test it?
local run playbook
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation